Skip to content

Commit cb03036

Browse files
authored
[CPU Profiler] Delete the "Profile app start up" button (#9358)
1 parent eb9c287 commit cb03036

File tree

3 files changed

+3
-28
lines changed

3 files changed

+3
-28
lines changed

packages/devtools_app/lib/src/screens/profiler/panes/controls/profiler_screen_controls.dart

Lines changed: 0 additions & 20 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,6 @@ import 'package:flutter/material.dart';
77

88
import '../../../../shared/analytics/constants.dart' as gac;
99
import '../../../../shared/framework/screen.dart';
10-
import '../../../../shared/globals.dart';
1110
import '../../../../shared/ui/common_widgets.dart';
1211
import '../../../../shared/ui/file_import.dart';
1312
import '../../../../shared/ui/vm_flag_widgets.dart';
@@ -103,25 +102,6 @@ class _SecondaryControls extends StatelessWidget {
103102
return Row(
104103
mainAxisAlignment: MainAxisAlignment.end,
105104
children: [
106-
if (serviceConnection
107-
.serviceManager
108-
.connectedApp!
109-
.isFlutterNativeAppNow)
110-
GaDevToolsButton(
111-
icon: Icons.timer,
112-
label: 'Profile app start up',
113-
tooltip:
114-
'Load all Dart CPU samples that occurred before \n'
115-
'the first Flutter frame was drawn (if available)',
116-
tooltipPadding: const EdgeInsets.all(denseSpacing),
117-
gaScreen: gac.cpuProfiler,
118-
gaSelection: gac.CpuProfilerEvents.profileAppStartUp.name,
119-
minScreenWidthForText: _profilingControlsMinScreenWidthForText,
120-
onPressed: !profilerBusy
121-
? controller.cpuProfilerController.loadAppStartUpProfile
122-
: null,
123-
),
124-
const SizedBox(width: denseSpacing),
125105
RefreshButton(
126106
label: 'Load all CPU samples',
127107
tooltip:

packages/devtools_app/release_notes/NEXT_RELEASE_NOTES.md

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,9 @@ TODO: Remove this section if there are not any general updates.
2727

2828
## CPU profiler updates
2929

30-
TODO: Remove this section if there are not any general updates.
30+
- Deleted the "Profile app start up" button in favor of the new Dart/Flutter
31+
`--profile-startup` CLI flags. -
32+
[#9358](https://github.com/flutter/devtools/pull/9358)
3133

3234
## Memory updates
3335

packages/devtools_app/test/screens/cpu_profiler/profiler_screen_test.dart

Lines changed: 0 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -34,13 +34,6 @@ void main() {
3434
expect(find.byType(StartStopRecordingButton), findsOneWidget);
3535
expect(find.byType(ClearButton), findsOneWidget);
3636
expect(find.text('Load all CPU samples'), findsOneWidget);
37-
if (scene
38-
.fakeServiceConnection
39-
.serviceManager
40-
.connectedApp!
41-
.isFlutterNativeAppNow) {
42-
expect(find.text('Profile app start up'), findsOneWidget);
43-
}
4437
expect(find.byType(CpuSamplingRateDropdown), findsOneWidget);
4538
expect(find.byType(OpenSaveButtonGroup), findsOneWidget);
4639
expect(find.byType(ProfileRecordingInstructions), findsOneWidget);

0 commit comments

Comments
 (0)