Skip to content

Commit e7e15e3

Browse files
committed
fix more tests
1 parent 3292469 commit e7e15e3

File tree

2 files changed

+13
-8
lines changed

2 files changed

+13
-8
lines changed

packages/devtools_app/test/screens/inspector_v2/layout_explorer/flex/arrow_test.dart

Lines changed: 9 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -10,6 +10,9 @@ import 'package:flutter_test/flutter_test.dart';
1010
import '../../../../test_infra/matchers/matchers.dart';
1111

1212
void main() {
13+
const relativeGoldenPath =
14+
'../../../../test_infra/goldens/inspector_v2/layout_explorer/flex';
15+
1316
group('Arrow Golden Tests', () {
1417
group('Unidirectional', () {
1518
Widget buildUnidirectionalArrowWrapper(ArrowType type) => Directionality(
@@ -30,31 +33,31 @@ void main() {
3033
await tester.pumpWidget(widget);
3134
await expectLater(
3235
find.byWidget(widget),
33-
matchesDevToolsGolden('goldens/arrow_unidirectional_left.png'),
36+
matchesDevToolsGolden('$relativeGoldenPath/arrow_unidirectional_left.png'),
3437
);
3538
}, skip: kIsWeb);
3639
testWidgets('up', (WidgetTester tester) async {
3740
final widget = buildUnidirectionalArrowWrapper(ArrowType.up);
3841
await tester.pumpWidget(widget);
3942
await expectLater(
4043
find.byWidget(widget),
41-
matchesDevToolsGolden('goldens/arrow_unidirectional_up.png'),
44+
matchesDevToolsGolden('$relativeGoldenPath/arrow_unidirectional_up.png'),
4245
);
4346
}, skip: kIsWeb);
4447
testWidgets('right', (WidgetTester tester) async {
4548
final widget = buildUnidirectionalArrowWrapper(ArrowType.right);
4649
await tester.pumpWidget(widget);
4750
await expectLater(
4851
find.byWidget(widget),
49-
matchesDevToolsGolden('goldens/arrow_unidirectional_right.png'),
52+
matchesDevToolsGolden('$relativeGoldenPath/arrow_unidirectional_right.png'),
5053
);
5154
}, skip: kIsWeb);
5255
testWidgets('down', (WidgetTester tester) async {
5356
final widget = buildUnidirectionalArrowWrapper(ArrowType.down);
5457
await tester.pumpWidget(widget);
5558
await expectLater(
5659
find.byWidget(widget),
57-
matchesDevToolsGolden('goldens/arrow_unidirectional_down.png'),
60+
matchesDevToolsGolden('$relativeGoldenPath/arrow_unidirectional_down.png'),
5861
);
5962
}, skip: kIsWeb);
6063
});
@@ -78,15 +81,15 @@ void main() {
7881
await tester.pumpWidget(widget);
7982
await expectLater(
8083
find.byWidget(widget),
81-
matchesDevToolsGolden('goldens/arrow_bidirectional_horizontal.png'),
84+
matchesDevToolsGolden('$relativeGoldenPath/arrow_bidirectional_horizontal.png'),
8285
);
8386
}, skip: kIsWeb);
8487
testWidgets('vertical', (WidgetTester tester) async {
8588
final widget = buildBidirectionalArrowWrapper(Axis.vertical);
8689
await tester.pumpWidget(widget);
8790
await expectLater(
8891
find.byWidget(widget),
89-
matchesDevToolsGolden('goldens/arrow_bidirectional_vertical.png'),
92+
matchesDevToolsGolden('$relativeGoldenPath/arrow_bidirectional_vertical.png'),
9093
);
9194
}, skip: kIsWeb);
9295
});

packages/devtools_app/test/screens/inspector_v2/layout_explorer/flex/flex_test.dart

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -18,6 +18,8 @@ import '../../../../test_infra/matchers/matchers.dart';
1818
// https://github.com/flutter/devtools/issues/1403
1919
void main() {
2020
const windowSize = Size(1750, 1750);
21+
const relativeGoldenPath =
22+
'../../../../test_infra/goldens/inspector_v2/layout_explorer/flex';
2123

2224
Map<String, Object> buildDiagnosticsNodeJson(Axis axis) => jsonDecode('''
2325
{
@@ -264,7 +266,7 @@ void main() {
264266
await tester.pumpAndSettle();
265267
await expectLater(
266268
find.byWidget(widget),
267-
matchesDevToolsGolden('goldens/story_of_row_layout.png'),
269+
matchesDevToolsGolden('$relativeGoldenPath/story_of_row_layout.png'),
268270
);
269271
}, skip: true);
270272

@@ -284,7 +286,7 @@ void main() {
284286
await pump(tester, widget);
285287
await expectLater(
286288
find.byWidget(widget),
287-
matchesDevToolsGolden('goldens/story_of_column_layout.png'),
289+
matchesDevToolsGolden('$relativeGoldenPath/story_of_column_layout.png'),
288290
);
289291
}, skip: true);
290292
}

0 commit comments

Comments
 (0)