Skip to content

Commit 0979e12

Browse files
authored
[CQ] migrate off deprecated Logger.error API (#8359)
`Logger.error(object)` is deprecated and the `String` API is preferred. https://github.com/JetBrains/intellij-community/blob/8e46815dd140357c19061ceba77416d40d81866d/platform/util/src/com/intellij/openapi/diagnostic/Logger.java#L378 (This logging isn't awesome and maybe we'll revisit but at least the API calls are clean.) Verifier output: ``` #Deprecated method com.intellij.openapi.diagnostic.Logger.error(Object) invocation Deprecated method com.intellij.openapi.diagnostic.Logger.error(java.lang.Object message) : void is invoked in io.flutter.vmService.VmServiceWrapper$10.onError(RPCError) : void ``` --- - [x] I’ve reviewed the contributor guide and applied the relevant portions to this PR. <details> <summary>Contribution guidelines:</summary><br> - See our [contributor guide]([https://github.com/dart-lang/sdk/blob/main/CONTRIBUTING.md](https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview) for general expectations for PRs. - Larger or significant changes should be discussed in an issue before creating a PR. - Dart contributions to our repos should follow the [Dart style guide](https://dart.dev/guides/language/effective-dart) and use `dart format`. - Java and Kotlin contributions should strive to follow Java and Kotlin best practices ([discussion](#8098)). </details>
1 parent 42d4559 commit 0979e12

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

src/io/flutter/vmService/VmServiceWrapper.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -600,7 +600,7 @@ private void checkDone() {
600600

601601
@Override
602602
public void onError(RPCError error) {
603-
LOG.error(error);
603+
LOG.error(error.toString());
604604
LOG.error(error.getMessage());
605605
LOG.error(error.getRequest());
606606
LOG.error(error.getDetails());

0 commit comments

Comments
 (0)