Skip to content

Commit 356ab80

Browse files
authored
[CQ] migrate off deprecated ComboBoxAction.createPopupActionGroup (#8355)
Migrate to preferred `createPopupActionGroup` override. ``` /** @deprecated override {@link #createPopupActionGroup(JComponent, DataContext)} instead */ ``` https://github.com/JetBrains/intellij-community/blob/01fab1c57cbe692a1e7f8df0f819386890abf6cc/platform/platform-api/src/com/intellij/openapi/actionSystem/ex/ComboBoxAction.java#L123 --- For superstition, I tested to make sure this is behavior preserving: <img width="634" height="404" alt="image" src="https://github.com/user-attachments/assets/ac4c617b-8760-46ed-a4cc-fedad02ed738" /> --- - [x] I’ve reviewed the contributor guide and applied the relevant portions to this PR. <details> <summary>Contribution guidelines:</summary><br> - See our [contributor guide]([https://github.com/dart-lang/sdk/blob/main/CONTRIBUTING.md](https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview) for general expectations for PRs. - Larger or significant changes should be discussed in an issue before creating a PR. - Dart contributions to our repos should follow the [Dart style guide](https://dart.dev/guides/language/effective-dart) and use `dart format`. - Java and Kotlin contributions should strive to follow Java and Kotlin best practices ([discussion](#8098)). </details>
1 parent 1fd1674 commit 356ab80

File tree

1 file changed

+1
-2
lines changed

1 file changed

+1
-2
lines changed

src/io/flutter/actions/DeviceSelectorAction.java

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -45,9 +45,8 @@ public class DeviceSelectorAction extends ComboBoxAction implements DumbAware {
4545
return ActionUpdateThread.BGT;
4646
}
4747

48-
@NotNull
4948
@Override
50-
protected DefaultActionGroup createPopupActionGroup(JComponent button) {
49+
protected @NotNull DefaultActionGroup createPopupActionGroup(@NotNull JComponent button, @NotNull DataContext dataContext) {
5150
final DefaultActionGroup group = new DefaultActionGroup();
5251
group.addAll(actions);
5352
return group;

0 commit comments

Comments
 (0)