You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
[perf] FlutterExternalIdeActionGroup: make action update thread explicit (#8236)
Making the action update thread explicit saves the platform from the
work of figuring it out for itself (required caching of potentially
unneeded data). From a related inspection:
> Reports actions, action groups and other ActionUpdateThreadAware
classes that do not explicitly state their mode.
> When an action or an action group defines its own update() method,
IntelliJ Platform tries to mimic the old synchronous way of calling
update() and getChildren() methods in the UI thread and supply it with
all the data in AnActionEvent.dataContext(). To do that, it caches all
the possible data on a background thread beforehand, even if it is not
needed.
> Provide one of the two modes ActionUpdateThread.EDT or
ActionUpdateThread.BGT by overriding the getActionUpdateThread() method.

---
- [x] I’ve reviewed the contributor guide and applied the relevant
portions to this PR.
<details>
<summary>Contribution guidelines:</summary><br>
- See our [contributor
guide]([https://github.com/dart-lang/sdk/blob/main/CONTRIBUTING.md](https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview)
for general expectations for PRs.
- Larger or significant changes should be discussed in an issue before
creating a PR.
- Dart contributions to our repos should follow the [Dart style
guide](https://dart.dev/guides/language/effective-dart) and use `dart
format`.
- Java and Kotlin contributions should strive to follow Java and Kotlin
best practices
([discussion](#8098)).
</details>
0 commit comments