Skip to content

Commit 8f63ee1

Browse files
authored
Enable the verifier on the presubmits (#8078)
This is follow up on #8034
1 parent 7ba2c3f commit 8f63ee1

File tree

3 files changed

+6
-6
lines changed

3 files changed

+6
-6
lines changed

.github/workflows/presubmit.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -34,7 +34,7 @@ jobs:
3434
strategy:
3535
fail-fast: true
3636
matrix:
37-
bot: [CHECK_BOT, DART_BOT, UNIT_TEST_BOT]
37+
bot: [CHECK_BOT, DART_BOT, UNIT_TEST_BOT, VERIFY_BOT]
3838
steps:
3939
- name: checkout
4040
uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683

.github/workflows/presubmit.yaml.template

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -32,7 +32,7 @@ jobs:
3232
strategy:
3333
fail-fast: true
3434
matrix:
35-
bot: [CHECK_BOT, DART_BOT, UNIT_TEST_BOT]
35+
bot: [CHECK_BOT, DART_BOT, UNIT_TEST_BOT, VERIFY_BOT]
3636
steps:
3737
- name: checkout
3838
uses: actions/checkout@8f4b7f84864484a7bf31766abe9204da3cbe65b3

tool/github.sh

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -43,7 +43,6 @@ dart pub get
4343
(cd tool/plugin; echo "dart pub get `pwd`"; dart pub get)
4444

4545
if [ "DART_BOT" = "$BOT" ] ; then
46-
4746
# Analyze the Dart code in the repo.
4847
echo "dart analyze"
4948
(cd flutter-idea/src; dart analyze)
@@ -63,20 +62,21 @@ if [ "DART_BOT" = "$BOT" ] ; then
6362
(cd tool/plugin; dart test/plugin_test.dart)
6463

6564
elif [ "CHECK_BOT" = "$BOT" ] ; then
66-
6765
# Run some validations on the repo code.
6866
./bin/plugin lint
6967

7068
# Check plugin-referenced urls for liveness.
7169
dart tool/grind.dart check-urls
7270

7371
elif [ "UNIT_TEST_BOT" = "$BOT" ] ; then
74-
7572
# Run unit tests.
7673
./bin/plugin test --no-setup
7774

78-
else
75+
elif [ "VERIFY_BOT" = "$BOT" ] ; then
76+
# Run the verifier for this version
77+
./bin/plugin verify
7978

79+
else
8080
# Run the build.
8181
./bin/plugin make --channel=stable --only-version=$IDEA_VERSION --no-setup
8282

0 commit comments

Comments
 (0)