Skip to content

Commit f3acef4

Browse files
authored
Run only one build presubmit with gradle (#8398)
This changes to not using the matrix to build two versions, and also use gradle to build which matches how we did the latest release.
1 parent a981f25 commit f3acef4

File tree

3 files changed

+3
-17
lines changed

3 files changed

+3
-17
lines changed

.github/workflows/presubmit.yaml

Lines changed: 1 addition & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -18,17 +18,11 @@ permissions:
1818
jobs:
1919
presubmit:
2020
runs-on: ubuntu-latest
21-
strategy:
22-
fail-fast: false
23-
matrix:
24-
version: [2024.3, 2025.1]
2521
steps:
2622
- name: checkout
2723
uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683
28-
- name: build ${{ matrix.version }}
24+
- name: build
2925
run: ./tool/github.sh
30-
env:
31-
IDEA_VERSION: ${{ matrix.version }}
3226
checker:
3327
runs-on: ubuntu-latest
3428
strategy:

.github/workflows/presubmit.yaml.template

Lines changed: 1 addition & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -16,17 +16,11 @@ permissions:
1616
jobs:
1717
presubmit:
1818
runs-on: ubuntu-latest
19-
strategy:
20-
fail-fast: false
21-
matrix:
22-
version: [@VERSIONS@]
2319
steps:
2420
- name: checkout
2521
uses: actions/checkout@8f4b7f84864484a7bf31766abe9204da3cbe65b3
26-
- name: build ${{ matrix.version }}
22+
- name: build
2723
run: ./tool/github.sh
28-
env:
29-
IDEA_VERSION: ${{ matrix.version }}
3024
checker:
3125
runs-on: ubuntu-latest
3226
strategy:

tool/github.sh

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -27,8 +27,6 @@ flutter config --no-analytics
2727
flutter doctor
2828
export FLUTTER_SDK=`pwd`/../flutter
2929

30-
echo "IDEA_VERSION=$IDEA_VERSION"
31-
3230
echo "java --version"
3331
java --version
3432

@@ -79,6 +77,6 @@ elif [ "VERIFY_BOT" = "$BOT" ] ; then
7977

8078
else
8179
# Run the build.
82-
./bin/plugin make --channel=stable --only-version=$IDEA_VERSION --no-setup
80+
./gradlew buildPlugin
8381

8482
fi

0 commit comments

Comments
 (0)