Skip to content

[video_player] Remove public access to the caption file #168823

@stuartmorgan-g

Description

@stuartmorgan-g

The existence of Future<ClosedCaptionFile>? get closedCaptionFile makes it impossible for the controller to transform the captions for its own use (e.g., sorting them for faster access) without extra complexity and memory; see flutter/packages#8347 for context. There's no good reason I can see for the getter to be public; if the caller who set the caption file wants it for their own purposes, they can keep it directly instead of getting it from the player later.

Removing that public API at the next breaking change would let us do more optimizations to captions in the future without worrying about breaking API compat.

Metadata

Metadata

Assignees

No one assigned

    Labels

    P2Important issues not at the top of the work listp: requires breaking changeA change that should be batched into the next breaking change to this packagep: video_playerThe Video Player pluginpackageflutter/packages repository. See also p: labels.team-ecosystemOwned by Ecosystem teamtriaged-ecosystemTriaged by Ecosystem team

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions