Skip to content
This repository was archived by the owner on Jun 13, 2024. It is now read-only.

Commit 18f1e8e

Browse files
justinmcguidezpl
andauthored
Remove rotation from Transformation demo description since it's not implemented (#968)
## Description The transformation demo does not include rotation, but the description and subtitle says it does. This PR removes mention of rotation. Rotation is not currently supported by InteractiveViewer under the hood, though someday I'd like it to! @guidezpl What's the process for updating an existing string like this? I couldn't figure it out by reading the [l10n readme](https://github.com/flutter/gallery/tree/main/lib/l10n#readme). ## Tests None. ## Issues Fixes #967 --------- Co-authored-by: Pierre-Louis <6655696+guidezpl@users.noreply.github.com>
1 parent 1835a5d commit 18f1e8e

File tree

3 files changed

+9
-4
lines changed

3 files changed

+9
-4
lines changed

lib/l10n/README.md

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -56,3 +56,8 @@ console to generate messages in the different locales.
5656
> unless necessary.
5757
5858
See `/third_party/dart/flutter_gallery/README.md` for how to import this file and export translations.
59+
60+
## Updating Existing Locale Messages
61+
62+
Modify the message in `intl_en.arb`, then run `flutter pub run grinder l10n`.
63+
This will update `intl_en_US.xml` for the translation console.

lib/l10n/intl_en.arb

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1787,11 +1787,11 @@
17871787
"@demo2dTransformationsTitle": {
17881788
"description": "Title for the 2D transformations demo."
17891789
},
1790-
"demo2dTransformationsSubtitle": "Pan, zoom, rotate",
1790+
"demo2dTransformationsSubtitle": "Pan and zoom",
17911791
"@demo2dTransformationsSubtitle": {
17921792
"description": "Subtitle for the 2D transformations demo."
17931793
},
1794-
"demo2dTransformationsDescription": "Tap to edit tiles, and use gestures to move around the scene. Drag to pan, pinch to zoom, rotate with two fingers. Press the reset button to return to the starting orientation.",
1794+
"demo2dTransformationsDescription": "Tap to edit tiles, and use gestures to move around the scene. Drag to pan and pinch with two fingers to zoom. Press the reset button to return to the starting orientation.",
17951795
"@demo2dTransformationsDescription": {
17961796
"description": "Description for the 2D transformations demo."
17971797
},

lib/l10n/intl_en_US.xml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1680,11 +1680,11 @@
16801680
<string
16811681
name="demo2dTransformationsSubtitle"
16821682
description="Subtitle for the 2D transformations demo."
1683-
>Pan, zoom, rotate</string>
1683+
>Pan and zoom</string>
16841684
<string
16851685
name="demo2dTransformationsDescription"
16861686
description="Description for the 2D transformations demo."
1687-
>Tap to edit tiles, and use gestures to move around the scene. Drag to pan, pinch to zoom, rotate with two fingers. Press the reset button to return to the starting orientation.</string>
1687+
>Tap to edit tiles, and use gestures to move around the scene. Drag to pan and pinch with two fingers to zoom. Press the reset button to return to the starting orientation.</string>
16881688
<string
16891689
name="demo2dTransformationsResetTooltip"
16901690
description="Tooltip for a button to reset the transformations (scale, translation) for the 2D transformations demo."

0 commit comments

Comments
 (0)