Skip to content

Commit 1511863

Browse files
committed
fix RECORD_AUDIO permission on Android when there is no permission
1 parent 952418d commit 1511863

File tree

1 file changed

+8
-6
lines changed

1 file changed

+8
-6
lines changed

packages/camera/camera_android_camerax/android/src/main/java/io/flutter/plugins/camerax/PendingRecordingProxyApi.java

Lines changed: 8 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -38,14 +38,16 @@ public PendingRecording asPersistentRecording(PendingRecording pigeonInstance) {
3838
@NonNull
3939
@Override
4040
public PendingRecording withAudioEnabled(PendingRecording pigeonInstance, boolean initialMuted) {
41-
if (!initialMuted
42-
&& ContextCompat.checkSelfPermission(
43-
getPigeonRegistrar().getContext(), Manifest.permission.RECORD_AUDIO)
44-
== PackageManager.PERMISSION_GRANTED) {
45-
return pigeonInstance.withAudioEnabled(false);
41+
// If initialMuted is false, only enable audio if permission is granted
42+
boolean hasPermission = ContextCompat.checkSelfPermission(
43+
getPigeonRegistrar().getContext(), Manifest.permission.RECORD_AUDIO)
44+
== PackageManager.PERMISSION_GRANTED;
45+
46+
if (hasPermission) {
47+
return pigeonInstance.withAudioEnabled(true);
4648
}
4749

48-
return pigeonInstance.withAudioEnabled(true);
50+
return pigeonInstance;
4951
}
5052

5153
@NonNull

0 commit comments

Comments
 (0)