Validate entire subtree

Author: LukasMirbt

packages/go_router_builder/lib/src/route_config.dart

@@ -599,19 +599,23 @@ abstract class RouteBaseConfig {
   factory RouteBaseConfig._fromAnnotation(
     ConstantReader reader,
     InterfaceElement element,
-    RouteBaseConfig? parent,
-  ) {
+    RouteBaseConfig? parent, {
+    bool isAncestorRelative = false,
+  }) {
     assert(!reader.isNull, 'reader should not be null');
     final InterfaceType type = reader.objectValue.type! as InterfaceType;
     final String typeName = type.element.name;
 
-    if (parent is RelativeGoRouteConfig && typeName == 'TypedGoRoute') {
+    if (isAncestorRelative && typeName == 'TypedGoRoute') {
       throw InvalidGenerationSourceError(
-        'TypedRelativeGoRoute cannot have a TypedGoRoute as a child.',
+        'TypedRelativeGoRoute cannot have a TypedGoRoute descendant.',
         element: element,
       );
     }
 
+    final bool isRelative =
+        isAncestorRelative || typeName == 'TypedRelativeGoRoute';
+
     final DartType typeParamType = type.typeArguments.single;
     if (typeParamType is! InterfaceType) {
       throw InvalidGenerationSourceError(
@@ -744,7 +748,8 @@ abstract class RouteBaseConfig {
         .read(_generateChildrenGetterName(typeName))
         .listValue
         .map<RouteBaseConfig>((DartObject e) => RouteBaseConfig._fromAnnotation(
-            ConstantReader(e), element, value)));
+            ConstantReader(e), element, value,
+            isAncestorRelative: isRelative)));
 
     return value;
   }

packages/go_router_builder/test_inputs/relative_route_with_absolute_sub_route.dart.expect

@@ -0,0 +1 @@
+TypedRelativeGoRoute cannot have a TypedGoRoute descendant.

packages/go_router_builder/test_inputs/relative_route_with_absolute_sub_route.dart renamed to packages/go_router_builder/test_inputs/relative_route_with_direct_absolute_sub_route.dart

@@ -0,0 +1,42 @@
+// Copyright 2013 The Flutter Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+import 'package:go_router/go_router.dart';
+
+mixin _$HomeRoute {}
+mixin _$ShellRoute {}
+mixin _$RelativeRoute {}
+mixin _$AbsoluteRoute {}
+
+@TypedGoRoute<HomeRoute>(
+  path: '/',
+  routes: <TypedRoute<RouteData>>[relativeRoute],
+)
+class HomeRoute extends GoRouteData with _$HomeRoute {
+  const HomeRoute();
+}
+
+const TypedRelativeGoRoute<RelativeRoute> relativeRoute =
+    TypedRelativeGoRoute<RelativeRoute>(
+  path: 'relative-route',
+  routes: <TypedRoute<RouteData>>[shellRoute],
+);
+
+const TypedShellRoute<ShellRoute> shellRoute =
+    TypedShellRoute<ShellRoute>(routes: <TypedRoute<RouteData>>[absoluteRoute]);
+
+const TypedGoRoute<AbsoluteRoute> absoluteRoute =
+    TypedGoRoute<AbsoluteRoute>(path: 'absolute-route');
+
+class RelativeRoute extends RelativeGoRouteData with _$RelativeRoute {
+  const RelativeRoute();
+}
+
+class ShellRoute extends ShellRouteData with _$ShellRoute {
+  const ShellRoute();
+}
+
+class AbsoluteRoute extends GoRouteData with _$AbsoluteRoute {
+  const AbsoluteRoute();
+}

packages/go_router_builder/test_inputs/relative_route_with_direct_absolute_sub_route.dart.expect

@@ -0,0 +1 @@
+TypedRelativeGoRoute cannot have a TypedGoRoute descendant.