[url_launcher] fix: tab traversal on web (#10020)

Author: pedromassango

packages/url_launcher/url_launcher_web/CHANGELOG.md

@@ -1,5 +1,6 @@
-## NEXT
+## 2.4.2
 
+* Fixes an issue that caused duplicate semantic nodes for `Link` widgets.
 * Updates minimum supported SDK version to Flutter 3.32/Dart 3.8.
 
 ## 2.4.1

packages/url_launcher/url_launcher_web/example/integration_test/link_widget_test.dart

@@ -206,6 +206,43 @@ void main() {
         maxScrolls: 1000,
       );
     });
+
+    testWidgets('MergeSemantics is always present to avoid duplicate nodes', (
+      WidgetTester tester,
+    ) async {
+      await tester.pumpWidget(
+        MaterialApp(
+          home: Scaffold(
+            body: Column(
+              children: <Widget>[
+                WebLinkDelegate(
+                  TestLinkInfo(
+                    uri: Uri.parse('https://dart.dev/xyz'),
+                    target: LinkTarget.blank,
+                    builder: (BuildContext context, FollowLink? followLink) {
+                      return ElevatedButton(
+                        onPressed: followLink,
+                        child: const Text('First Button'),
+                      );
+                    },
+                  ),
+                ),
+              ],
+            ),
+          ),
+        ),
+      );
+
+      await tester.pumpAndSettle();
+
+      final Finder buttonFinder = find.byType(ElevatedButton);
+      expect(buttonFinder, findsOneWidget);
+
+      final Element buttonElement = tester.element(buttonFinder);
+      final MergeSemantics? parentWidget = buttonElement
+          .findAncestorWidgetOfExactType<MergeSemantics>();
+      expect(parentWidget, isNotNull);
+    });
   });
 
   group('Follows links', () {
@@ -895,17 +932,13 @@ void main() {
           isLink: true,
           identifier: 'test-link-12',
           // linkUrl: 'https://foobar/example?q=1',
-          children: <Matcher>[
-            matchesSemantics(
-              hasTapAction: true,
-              hasEnabledState: true,
-              hasFocusAction: true,
-              isEnabled: true,
-              isButton: true,
-              isFocusable: true,
-              label: 'Button Link Text',
-            ),
-          ],
+          hasTapAction: true,
+          hasEnabledState: true,
+          hasFocusAction: true,
+          isEnabled: true,
+          isButton: true,
+          isFocusable: true,
+          label: 'Button Link Text',
         ),
       );
 
@@ -941,7 +974,9 @@ void main() {
       final Finder linkFinder = find.byKey(linkKey);
       expect(
         tester.getSemantics(
-          find.descendant(of: linkFinder, matching: find.byType(Semantics)),
+          find
+              .descendant(of: linkFinder, matching: find.byType(Semantics))
+              .first,
         ),
         matchesSemantics(
           isLink: true,

packages/url_launcher/url_launcher_web/example/pubspec.yaml

@@ -2,8 +2,8 @@ name: regular_integration_tests
 publish_to: none
 
 environment:
-  sdk: ^3.8.0
-  flutter: ">=3.32.0"
+  sdk: ^3.10.0
+  flutter: ">=3.38.0"
 
 dependencies:
   flutter:

packages/url_launcher/url_launcher_web/lib/src/link.dart

@@ -117,13 +117,15 @@ class WebLinkDelegateState extends State<WebLinkDelegate> {
   }
 
   Widget _buildChild(BuildContext context) {
-    return Semantics(
-      link: true,
-      identifier: _semanticsIdentifier,
-      linkUrl: widget.link.uri,
-      child: widget.link.builder(
-        context,
-        widget.link.isDisabled ? null : _followLink,
+    return MergeSemantics(
+      child: Semantics(
+        link: true,
+        identifier: _semanticsIdentifier,
+        linkUrl: widget.link.uri,
+        child: widget.link.builder(
+          context,
+          widget.link.isDisabled ? null : _followLink,
+        ),
       ),
     );
   }

packages/url_launcher/url_launcher_web/pubspec.yaml

@@ -2,11 +2,11 @@ name: url_launcher_web
 description: Web platform implementation of url_launcher
 repository: https://github.com/flutter/packages/tree/main/packages/url_launcher/url_launcher_web
 issue_tracker: https://github.com/flutter/flutter/issues?q=is%3Aissue+is%3Aopen+label%3A%22p%3A+url_launcher%22
-version: 2.4.1
+version: 2.4.2
 
 environment:
-  sdk: ^3.8.0
-  flutter: ">=3.32.0"
+  sdk: ^3.10.0
+  flutter: ">=3.38.0"
 
 flutter:
   plugin: