Skip to content

Commit 8f2fd36

Browse files
authored
[google_maps_flutter_platform_interface] Add iOS warning for PinConfig (#11100)
Add iOS warning for PinConfig usage in BitmapDescriptor iOS implementation for Advanced Markers: #10508 Related issue: flutter/flutter#155526 ## Pre-Review Checklist **Note**: The Flutter team is currently trialing the use of [Gemini Code Assist for GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code). Comments from the `gemini-code-assist` bot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed. [^1]: Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling.
1 parent 76183f4 commit 8f2fd36

File tree

3 files changed

+17
-2
lines changed

3 files changed

+17
-2
lines changed

packages/google_maps_flutter/google_maps_flutter_platform_interface/CHANGELOG.md

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,6 @@
1-
## NEXT
1+
## 2.14.2
22

3+
* Adds documentation about iOS rendering issue with `PinConfig`.
34
* Updates minimum supported SDK version to Flutter 3.35/Dart 3.9.
45

56
## 2.14.1

packages/google_maps_flutter/google_maps_flutter_platform_interface/lib/src/types/bitmap.dart

Lines changed: 14 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -363,6 +363,11 @@ abstract class BitmapDescriptor {
363363
///
364364
/// See [PinConfig] for more information on the parameters.
365365
///
366+
/// WARNING: On iOS, using a PinConfig may result in the marker not showing.
367+
/// For details and updates, see https://issuetracker.google.com/issues/370536110.
368+
/// If this issue has not been fixed in the version of the Google Maps SDK you
369+
/// are using, consider using an asset or bitmap for customization on iOS.
370+
///
366371
/// Returns a new [PinConfig] instance.
367372
static BitmapDescriptor pinConfig({
368373
Color? backgroundColor,
@@ -1058,6 +1063,10 @@ class BytesMapBitmap extends MapBitmap {
10581063
/// )
10591064
/// ```
10601065
///
1066+
/// WARNING: On iOS, using a PinConfig may result in the marker not showing.
1067+
/// For details and updates, see https://issuetracker.google.com/issues/370536110.
1068+
/// If this issue has not been fixed in the version of the Google Maps SDK you
1069+
/// are using, consider using an asset or bitmap for customization on iOS.
10611070
class PinConfig extends BitmapDescriptor {
10621071
/// Constructs a [PinConfig] that is created from a pin configuration.
10631072
///
@@ -1068,6 +1077,11 @@ class PinConfig extends BitmapDescriptor {
10681077
/// pin marker.
10691078
///
10701079
/// At least one of the parameters must not be null.
1080+
///
1081+
/// WARNING: On iOS, using a PinConfig may result in the marker not showing.
1082+
/// For details and updates, see https://issuetracker.google.com/issues/370536110.
1083+
/// If this issue has not been fixed in the version of the Google Maps SDK you
1084+
/// are using, consider using an asset or bitmap for customization on iOS.
10711085
const PinConfig({this.backgroundColor, this.borderColor, this.glyph})
10721086
: assert(
10731087
backgroundColor != null || borderColor != null || glyph != null,

packages/google_maps_flutter/google_maps_flutter_platform_interface/pubspec.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@ repository: https://github.com/flutter/packages/tree/main/packages/google_maps_f
44
issue_tracker: https://github.com/flutter/flutter/issues?q=is%3Aissue+is%3Aopen+label%3A%22p%3A+maps%22
55
# NOTE: We strongly prefer non-breaking changes, even at the expense of a
66
# less-clean API. See https://flutter.dev/go/platform-interface-breaking-changes
7-
version: 2.14.1
7+
version: 2.14.2
88

99
environment:
1010
sdk: ^3.9.0

0 commit comments

Comments
 (0)