update

Author: chunhtai

script/tool/lib/src/version_check_command.dart

@@ -232,10 +232,16 @@ class VersionCheckCommand extends PackageLoopingCommand {
 
       // The changelog.md and pubspec.yaml's version should not be updated directly.
       if (changedFiles.contains(package.changelogFile.path)) {
+        printError(
+            'This package uses batch release, so CHANGELOG.md should not be changed directly.\n'
+            'Instead, create a pending changelog file in pending_changelogs folder.');
         errors.add('CHANGELOG.md changed');
       }
       if (changedFiles.contains(package.pubspecFile.path)) {
         if (versionState != _CurrentVersionState.unchanged) {
+          printError(
+              'This package uses batch release, so the version in pubspec.yaml should not be changed directly.\n'
+              'Instead, create a pending changelog file in pending_changelogs folder.');
           errors.add('pubspec.yaml version changed');
         }
       }

script/tool/test/common/repository_package_test.dart

@@ -277,7 +277,12 @@ release:
           createFakePlugin('a_plugin', packagesDir);
       plugin.ciConfigFile.writeAsStringSync('not a map');
 
-      expect(() => plugin.parseCiConfig(), throwsFormatException);
+      expect(
+          () => plugin.parseCiConfig(),
+          throwsA(isA<FormatException>().having(
+              (FormatException e) => e.message,
+              'message',
+              contains('Root of ci_config.yaml must be a map'))));
     });
 
     test('reports unknown keys', () {
@@ -287,7 +292,12 @@ release:
 foo: bar
 ''');
 
-      expect(() => plugin.parseCiConfig(), throwsFormatException);
+      expect(
+          () => plugin.parseCiConfig(),
+          throwsA(isA<FormatException>().having(
+              (FormatException e) => e.message,
+              'message',
+              contains('Unknown key `foo` in config'))));
     });
 
     test('reports invalid values', () {
@@ -298,7 +308,12 @@ release:
   batch: not-a-bool
 ''');
 
-      expect(() => plugin.parseCiConfig(), throwsFormatException);
+      expect(
+          () => plugin.parseCiConfig(),
+          throwsA(isA<FormatException>().having(
+              (FormatException e) => e.message,
+              'message',
+              contains('Invalid value `not-a-bool` for key `release.batch`'))));
     });
   });
 
@@ -356,7 +371,12 @@ version: minor
           package.pendingChangelogsDirectory.childFile('a.yaml');
       changelogFile.writeAsStringSync('not yaml');
 
-      expect(() => package.getPendingChangelogs(), throwsFormatException);
+      expect(
+          () => package.getPendingChangelogs(),
+          throwsA(isA<FormatException>().having(
+              (FormatException e) => e.message,
+              'message',
+              contains('Expected a YAML map, but found String'))));
     });
 
     test('ignores template.yaml', () {
@@ -382,22 +402,5 @@ version: skip
       expect(changelogs, hasLength(1));
       expect(changelogs[0].changelog, 'A');
     });
-
-    test('returns an error for a non-yaml file', () {
-      final RepositoryPackage package =
-          createFakePackage('a_package', packagesDir);
-      package.pendingChangelogsDirectory.createSync();
-      package.pendingChangelogsDirectory
-          .childFile('a.yaml')
-          .writeAsStringSync('''
-changelog: A
-version: patch
-''');
-      package.pendingChangelogsDirectory
-          .childFile('a.txt')
-          .writeAsStringSync('text');
-
-      expect(() => package.getPendingChangelogs(), throwsFormatException);
-    });
   });
 }

script/tool/test/version_check_command_test.dart

@@ -322,14 +322,28 @@ void main() {
           ]));
     });
 
-    test('skips version check with post-release label', () async {
+    test(
+        'ignore changelog and pubspec yaml version modifications check with post-release label',
+        () async {
       final RepositoryPackage package =
           createFakePackage('package', packagesDir, version: '1.0.0');
       package.ciConfigFile.writeAsStringSync('''
 release:
-  batch: false
+  batch: true
 ''');
 
+      gitProcessRunner.mockProcessesForExecutable['git-diff'] =
+          <FakeProcessInfo>[
+        FakeProcessInfo(MockProcess(stdout: '''
+packages/package/CHANGELOG.md
+packages/package/pubspec.yaml
+''')),
+      ];
+      gitProcessRunner.mockProcessesForExecutable['git-show'] =
+          <FakeProcessInfo>[
+        FakeProcessInfo(MockProcess(stdout: 'version: 1.0.0')),
+      ];
+
       final List<String> output = await runCapturingPrint(runner, <String>[
         'version-check',
         '--base-sha=main',
@@ -346,7 +360,7 @@ release:
     });
 
     test(
-        'fails for batch release package with no new changelog and post-release label',
+        'fails for batch release package with no new changelog',
         () async {
       final RepositoryPackage package =
           createFakePackage('package', packagesDir, version: '1.0.0');
@@ -375,7 +389,6 @@ release:
         'version-check',
         '--base-sha=main',
         '--check-for-missing-changes',
-        '--pr-labels=post-release-package',
       ], errorHandler: (Error e) {
         commandError = e;
       });