Skip to content

Commit b7caa1d

Browse files
authored
[file_selector] updates build files to use JVM 17 (#10097)
Update minimum flutter version to 3.35 to force a minimum AGP version to something that requires java 17. part of [#176027](flutter/flutter#176027) All dart code changes were formatter changes. ## Pre-Review Checklist **Note**: The Flutter team is currently trialing the use of [Gemini Code Assist for GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code). Comments from the `gemini-code-assist` bot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed. [^1]: Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling.
1 parent 287739d commit b7caa1d

File tree

6 files changed

+18
-12
lines changed

6 files changed

+18
-12
lines changed

packages/file_selector/file_selector/example/android/app/build.gradle

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -28,12 +28,12 @@ android {
2828
ndkVersion = flutter.ndkVersion
2929

3030
compileOptions {
31-
sourceCompatibility = JavaVersion.VERSION_11
32-
targetCompatibility = JavaVersion.VERSION_11
31+
sourceCompatibility = JavaVersion.VERSION_17
32+
targetCompatibility = JavaVersion.VERSION_17
3333
}
3434

3535
kotlinOptions {
36-
jvmTarget = '11'
36+
jvmTarget = '17'
3737
}
3838

3939
sourceSets {

packages/file_selector/file_selector_android/CHANGELOG.md

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,8 @@
1+
## 0.5.2
2+
3+
* Updates Java compatibility version to 17.
4+
* Updates minimum supported SDK version to Flutter 3.35/Dart 3.9.
5+
16
## 0.5.1+17
27

38
* Updates Pigeon to 26.x.

packages/file_selector/file_selector_android/android/build.gradle

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -26,8 +26,8 @@ android {
2626
compileSdk = flutter.compileSdkVersion
2727

2828
compileOptions {
29-
sourceCompatibility = JavaVersion.VERSION_11
30-
targetCompatibility = JavaVersion.VERSION_11
29+
sourceCompatibility = JavaVersion.VERSION_17
30+
targetCompatibility = JavaVersion.VERSION_17
3131
}
3232

3333
defaultConfig {

packages/file_selector/file_selector_android/example/android/app/build.gradle

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -28,8 +28,8 @@ android {
2828
ndkVersion = flutter.ndkVersion
2929

3030
compileOptions {
31-
sourceCompatibility = JavaVersion.VERSION_11
32-
targetCompatibility = JavaVersion.VERSION_11
31+
sourceCompatibility = JavaVersion.VERSION_17
32+
targetCompatibility = JavaVersion.VERSION_17
3333
}
3434

3535
defaultConfig {

packages/file_selector/file_selector_android/lib/src/file_selector_api.g.dart

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -244,8 +244,9 @@ class FileSelectorApi {
244244
BinaryMessenger? binaryMessenger,
245245
String messageChannelSuffix = '',
246246
}) : pigeonVar_binaryMessenger = binaryMessenger,
247-
pigeonVar_messageChannelSuffix =
248-
messageChannelSuffix.isNotEmpty ? '.$messageChannelSuffix' : '';
247+
pigeonVar_messageChannelSuffix = messageChannelSuffix.isNotEmpty
248+
? '.$messageChannelSuffix'
249+
: '';
249250
final BinaryMessenger? pigeonVar_binaryMessenger;
250251

251252
static const MessageCodec<Object?> pigeonChannelCodec = _PigeonCodec();

packages/file_selector/file_selector_android/pubspec.yaml

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -2,11 +2,11 @@ name: file_selector_android
22
description: Android implementation of the file_selector package.
33
repository: https://github.com/flutter/packages/tree/main/packages/file_selector/file_selector_android
44
issue_tracker: https://github.com/flutter/flutter/issues?q=is%3Aissue+is%3Aopen+label%3A%22p%3A+file_selector%22
5-
version: 0.5.1+17
5+
version: 0.5.2
66

77
environment:
8-
sdk: ^3.7.0
9-
flutter: ">=3.29.0"
8+
sdk: ^3.9.0
9+
flutter: ">=3.35.0"
1010

1111
flutter:
1212
plugin:

0 commit comments

Comments
 (0)