Skip to content

Commit ebe5367

Browse files
[google_sign_in] Clean up Java code (#8241)
Removes the legacy public native interface to the sign-in plugin, which was inherently linked to raw method channels (which we no longer use) and the structure of the Google Sign-In native SDK (which is deprecated), so we don't want to continue supporting. I (unsurprisingly, as native->native plugin dependencies are very rare) can't find any evidence that any public plugin has ever directly used this Java code. The original use case this was added for was internal, and no longer exists (see b/158361263). The test file being deleted is specific to the legacy interface. There is already an almost-exact duplicate of that test file that tests the Pigeon interface.
1 parent 45bcc32 commit ebe5367

File tree

5 files changed

+9
-718
lines changed

5 files changed

+9
-718
lines changed

packages/google_sign_in/google_sign_in_android/CHANGELOG.md

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,7 @@
1+
## 6.1.34
2+
3+
* Removes unnecessary native code.
4+
15
## 6.1.33
26

37
* Updates Pigeon for non-nullable collection type support.

0 commit comments

Comments
 (0)