[url_launcher_ios] Migrate XCTest to Swift Testing (#10780)

jmagman · web-flow · commit f709ea1ceff0 · 2026-01-21T21:45:11.000Z
Part of flutter/flutter#180787 Add some test parameterization. ``` ◇ Test run started. ↳ Testing Library Version: 102 (arm64-apple-ios13.0-simulator) ◇ Suite URLLauncherTests started. ◇ Test canLaunchFailureWithInvalidURL() started. ◇ Test canLaunch(url:expected:) started. ◇ Test launchWithUniversalLinks() started. ◇ Test launch(url:expected:) started. ◇ Test launchSafariViewControllerWithClose() started. ◇ Test launchSafariViewControllerFailureWithNoViewPresenter() started. ◇ Test launchWithoutUniversalLinks() started. ◇ Test launchFailureWithInvalidURL() started. ◇ Passing 2 arguments url → "good://url", expected → .success to launch(url:expected:) ◇ Passing 2 arguments url → "bad://url", expected → .failure to launch(url:expected:) 2026-01-12 12:53:39.222409-0800 Runner[62355:494810] [Warning] Attempting to load the view of a view controller while it is deallocating is not allowed and may result in undefined behavior (<SFSafariViewController: 0x1018cd200>) ◇ Passing 2 arguments url → "bad://url", expected → .failure to canLaunch(url:expected:) ◇ Passing 2 arguments url → "good://url", expected → .success to canLaunch(url:expected:) ✔ Test canLaunchFailureWithInvalidURL() passed after 0.001 seconds. ✔ Test launchWithUniversalLinks() passed after 0.001 seconds. ✔ Test launchSafariViewControllerWithClose() passed after 0.042 seconds. ✔ Test launchWithoutUniversalLinks() passed after 0.042 seconds. ✔ Test launchSafariViewControllerFailureWithNoViewPresenter() passed after 0.042 seconds. ✔ Test launchFailureWithInvalidURL() passed after 0.042 seconds. ​​​​✔ Test launch(url:expected:) passed after 0.043 seconds. ✔ Test canLaunch(url:expected:) passed after 0.043 seconds. ✔ Suite URLLauncherTests passed after 0.043 seconds. ✔ Test run with 8 tests passed after 0.043 seconds. ``` https://logs.chromium.org/logs/flutter/buildbucket/cr-buildbucket/8692848274232556065/+/u/Run_package_tests/native_test/stdout Adding CHANGELOG override per #10761 (comment) ## Pre-Review Checklist **Note**: The Flutter team is currently trialing the use of [Gemini Code Assist for GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code). Comments from the `gemini-code-assist` bot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed. [^1]: Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling.
diff --git a/packages/url_launcher/url_launcher_ios/example/ios/Runner.xcodeproj/project.pbxproj b/packages/url_launcher/url_launcher_ios/example/ios/Runner.xcodeproj/project.pbxproj
@@ -650,7 +650,7 @@
 				MTL_FAST_MATH = YES;
 				PRODUCT_BUNDLE_IDENTIFIER = dev.flutter.plugins.RunnerTests;
 				PRODUCT_NAME = "$(TARGET_NAME)";
-				SWIFT_VERSION = 5.0;
+				SWIFT_VERSION = 6.0;
 				TEST_HOST = "$(BUILT_PRODUCTS_DIR)/Runner.app/Runner";
 			};
 			name = Debug;
@@ -671,7 +671,7 @@
 				MTL_FAST_MATH = YES;
 				PRODUCT_BUNDLE_IDENTIFIER = dev.flutter.plugins.RunnerTests;
 				PRODUCT_NAME = "$(TARGET_NAME)";
-				SWIFT_VERSION = 5.0;
+				SWIFT_VERSION = 6.0;
 				TEST_HOST = "$(BUILT_PRODUCTS_DIR)/Runner.app/Runner";
 			};
 			name = Release;
diff --git a/packages/url_launcher/url_launcher_ios/example/ios/RunnerTests/URLLauncherTests.swift b/packages/url_launcher/url_launcher_ios/example/ios/RunnerTests/URLLauncherTests.swift
@@ -3,7 +3,7 @@
 // found in the LICENSE file.
 
 import Flutter
-import XCTest
+import Testing
 
 @testable import url_launcher_ios
 
@@ -31,7 +31,8 @@ final class StubViewPresenterProvider: ViewPresenterProvider {
   }
 }
 
-final class URLLauncherTests: XCTestCase {
+@MainActor
+struct URLLauncherTests {
 
   private func createPlugin(
     launcher: FakeLauncher = FakeLauncher(), viewPresenter: ViewPresenter? = TestViewPresenter()
@@ -41,147 +42,131 @@ final class URLLauncherTests: XCTestCase {
       viewPresenterProvider: StubViewPresenterProvider(viewPresenter: viewPresenter))
   }
 
-  func testCanLaunchSuccess() {
-    let result = createPlugin().canLaunchUrl(url: "good://url")
-    XCTAssertEqual(result, .success)
+  @Test(arguments: [
+    ("good://url", LaunchResult.success),
+    ("bad://url", .failure),
+  ])
+  func canLaunch(url: String, expected: LaunchResult) {
+    let result = createPlugin().canLaunchUrl(url: url)
+    #expect(result == expected)
   }
 
-  func testCanLaunchFailure() {
-    let result = createPlugin().canLaunchUrl(url: "bad://url")
-    XCTAssertEqual(result, .failure)
-  }
-
-  func testCanLaunchFailureWithInvalidURL() {
+  @Test func canLaunchFailureWithInvalidURL() {
     let result = createPlugin().canLaunchUrl(url: "urls can't have spaces")
-
     if urlParsingIsStrict() {
-      XCTAssertEqual(result, .invalidUrl)
+      #expect(result == .invalidUrl)
     } else {
-      XCTAssertEqual(result, .failure)
+      #expect(result == .failure)
     }
   }
 
-  func testLaunchSuccess() {
-    let expectation = XCTestExpectation(description: "completion called")
-    createPlugin().launchUrl(url: "good://url", universalLinksOnly: false) { result in
-      switch result {
-      case .success(let details):
-        XCTAssertEqual(details, .success)
-      case .failure(let error):
-        XCTFail("Unexpected error: \(error)")
-      }
-      expectation.fulfill()
-    }
-
-    wait(for: [expectation], timeout: 1)
-  }
-
-  func testLaunchFailure() {
-    let expectation = XCTestExpectation(description: "completion called")
-    createPlugin().launchUrl(url: "bad://url", universalLinksOnly: false) { result in
-      switch result {
-      case .success(let details):
-        XCTAssertEqual(details, .failure)
-      case .failure(let error):
-        XCTFail("Unexpected error: \(error)")
+  @Test(arguments: [
+    ("good://url", LaunchResult.success),
+    ("bad://url", .failure),
+  ])
+  func launch(url: String, expected: LaunchResult) async {
+    await confirmation("completion called") { confirmed in
+      createPlugin().launchUrl(url: url, universalLinksOnly: false) { result in
+        switch result {
+        case .success(let details):
+          #expect(details == expected)
+        case .failure(let error):
+          Issue.record("Unexpected error: \(error)")
+        }
+        confirmed()
       }
-      expectation.fulfill()
     }
-
-    wait(for: [expectation], timeout: 1)
   }
 
-  func testLaunchFailureWithInvalidURL() {
-    let expectation = XCTestExpectation(description: "completion called")
-    createPlugin().launchUrl(url: "urls can't have spaces", universalLinksOnly: false) { result in
-      switch result {
-      case .success(let details):
-        if urlParsingIsStrict() {
-          XCTAssertEqual(details, .invalidUrl)
-        } else {
-          XCTAssertEqual(details, .failure)
+  @Test func launchFailureWithInvalidURL() async {
+    await confirmation("completion called") { confirmed in
+      createPlugin().launchUrl(url: "urls can't have spaces", universalLinksOnly: false) { result in
+        switch result {
+        case .success(let details):
+          if urlParsingIsStrict() {
+            #expect(details == .invalidUrl)
+          } else {
+            #expect(details == .failure)
+          }
+        case .failure(let error):
+          Issue.record("Unexpected error: \(error)")
         }
-      case .failure(let error):
-        XCTFail("Unexpected error: \(error)")
+        confirmed()
       }
-      expectation.fulfill()
     }
-
-    wait(for: [expectation], timeout: 1)
   }
 
-  func testLaunchWithoutUniversalLinks() {
+  @Test func launchWithoutUniversalLinks() async throws {
     let launcher = FakeLauncher()
     let plugin = createPlugin(launcher: launcher)
 
-    let expectation = XCTestExpectation(description: "completion called")
-    plugin.launchUrl(url: "good://url", universalLinksOnly: false) { result in
-      switch result {
-      case .success(let details):
-        XCTAssertEqual(details, .success)
-      case .failure(let error):
-        XCTFail("Unexpected error: \(error)")
+    await confirmation("completion called") { confirmed in
+      plugin.launchUrl(url: "good://url", universalLinksOnly: false) { result in
+        switch result {
+        case .success(let details):
+          #expect(details == .success)
+        case .failure(let error):
+          Issue.record("Unexpected error: \(error)")
+        }
+        confirmed()
       }
-      expectation.fulfill()
     }
-
-    wait(for: [expectation], timeout: 1)
-    XCTAssertEqual(launcher.passedOptions?[.universalLinksOnly] as? Bool, false)
+    let passedOptions = try #require(launcher.passedOptions)
+    #expect(passedOptions[.universalLinksOnly] as? Bool == false)
   }
 
-  func testLaunchWithUniversalLinks() {
+  @Test func launchWithUniversalLinks() async throws {
     let launcher = FakeLauncher()
     let plugin = createPlugin(launcher: launcher)
 
-    let expectation = XCTestExpectation(description: "completion called")
-    plugin.launchUrl(url: "good://url", universalLinksOnly: true) { result in
-      switch result {
-      case .success(let details):
-        XCTAssertEqual(details, .success)
-      case .failure(let error):
-        XCTFail("Unexpected error: \(error)")
+    await confirmation("completion called") { confirmed in
+      plugin.launchUrl(url: "good://url", universalLinksOnly: true) { result in
+        switch result {
+        case .success(let details):
+          #expect(details == .success)
+        case .failure(let error):
+          Issue.record("Unexpected error: \(error)")
+        }
+        confirmed()
       }
-      expectation.fulfill()
     }
-
-    wait(for: [expectation], timeout: 1)
-    XCTAssertEqual(launcher.passedOptions?[.universalLinksOnly] as? Bool, true)
+    let passedOptions = try #require(launcher.passedOptions)
+    #expect(passedOptions[.universalLinksOnly] as? Bool == true)
   }
 
-  func testLaunchSafariViewControllerWithClose() {
+  @Test func launchSafariViewControllerWithClose() async {
     let launcher = FakeLauncher()
     let viewPresenter = TestViewPresenter()
     let plugin = createPlugin(launcher: launcher, viewPresenter: viewPresenter)
 
-    let expectation = XCTestExpectation(description: "completion called")
-    plugin.openUrlInSafariViewController(url: "https://flutter.dev") { result in
-      switch result {
-      case .success(let details):
-        XCTAssertEqual(details, .dismissed)
-      case .failure(let error):
-        XCTFail("Unexpected error: \(error)")
+    await confirmation("completion called") { confirmed in
+      plugin.openUrlInSafariViewController(url: "https://flutter.dev") { result in
+        switch result {
+        case .success(let details):
+          #expect(details == .dismissed)
+        case .failure(let error):
+          Issue.record("Unexpected error: \(error)")
+        }
+        confirmed()
       }
-      expectation.fulfill()
+      plugin.closeSafariViewController()
     }
-    plugin.closeSafariViewController()
-    wait(for: [expectation], timeout: 30)
-    XCTAssertNotNil(viewPresenter.presentedController)
+    #expect(viewPresenter.presentedController != nil)
   }
 
-  func testLaunchSafariViewControllerFailureWithNoViewPresenter() {
-    let expectation = XCTestExpectation(description: "completion called")
-    createPlugin(viewPresenter: nil).openUrlInSafariViewController(url: "https://flutter.dev") {
-      result in
-      switch result {
-      case .success(let details):
-        XCTAssertEqual(details, .noUI)
-      case .failure(let error):
-        XCTFail("Unexpected error: \(error)")
+  @Test func launchSafariViewControllerFailureWithNoViewPresenter() async {
+    await confirmation("completion called") { confirmed in
+      createPlugin(viewPresenter: nil).openUrlInSafariViewController(url: "https://flutter.dev") {
+        result in
+        switch result {
+        case .success(let details):
+          #expect(details == .noUI)
+        case .failure(let error):
+          Issue.record("Unexpected error: \(error)")
+        }
+        confirmed()
       }
-      expectation.fulfill()
     }
-
-    wait(for: [expectation], timeout: 1)
   }
 
 }
