[webview_flutter] Update Pigeon for Kotlin 1.8 compat #10486
Merged
+9
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rolls Pigeon to 26.1.2 in `webview_flutter_android` to pick up a fix for a Kotlin 1.8 compatibility issue. Fixes flutter/flutter#178756
Collaborator
Author
|
test-exempt: rolling dependencies |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request correctly addresses a Kotlin 1.8 compatibility issue by updating the Pigeon dependency to version 26.1.2 in the webview_flutter_android package. The changes are well-executed, including the necessary updates to pubspec.yaml, CHANGELOG.md, and the regenerated Pigeon files. The code is clean and the changes are consistent with the PR's objective. I have no further comments; the PR is ready for merging.
stuartmorgan-g
added
the
autosubmit
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rolls Pigeon to 26.1.2 in
webview_flutter_androidto pick up a fix for a Kotlin 1.8 compatibility issue.Fixes flutter/flutter#178756
Pre-Review Checklist
[shared_preferences]pubspec.yamlwith an appropriate new version according to the pub versioning philosophy, or I have commented below to indicate which version change exemption this PR falls under1.CHANGELOG.mdto add a description of the change, following repository CHANGELOG style, or I have commented below to indicate which CHANGELOG exemption this PR falls under1.///).Footnotes
Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling. ↩ ↩2 ↩3