Skip to content

Commit 10dab1e

Browse files
committed
🎨 Improve usage of else
1 parent 7e967ac commit 10dab1e

File tree

4 files changed

+35
-45
lines changed

4 files changed

+35
-45
lines changed

lib/src/delegates/asset_picker_builder_delegate.dart

Lines changed: 20 additions & 27 deletions
Original file line numberDiff line numberDiff line change
@@ -227,9 +227,8 @@ abstract class AssetPickerBuilderDelegate<A, P> {
227227
}
228228
if (isAssetsEmpty) {
229229
return const Text('Nothing here.');
230-
} else {
231-
return w!;
232230
}
231+
return w!;
233232
},
234233
child: PlatformProgressIndicator(
235234
color: theme.iconTheme.color,
@@ -397,12 +396,11 @@ abstract class AssetPickerBuilderDelegate<A, P> {
397396
),
398397
),
399398
);
400-
} else {
401-
return IconButton(
402-
onPressed: Navigator.of(context).maybePop,
403-
icon: const Icon(Icons.close),
404-
);
405399
}
400+
return IconButton(
401+
onPressed: Navigator.of(context).maybePop,
402+
icon: const Icon(Icons.close),
403+
);
406404
}(),
407405
);
408406
}
@@ -896,12 +894,11 @@ class DefaultAssetPickerBuilderDelegate
896894
builder: (_, bool isAssetsEmpty, __) {
897895
if (isAssetsEmpty) {
898896
return const Text('Nothing here.');
899-
} else {
900-
return PlatformProgressIndicator(
901-
color: theme.iconTheme.color,
902-
size: Screens.width / gridCount / 3,
903-
);
904897
}
898+
return PlatformProgressIndicator(
899+
color: theme.iconTheme.color,
900+
size: Screens.width / gridCount / 3,
901+
);
905902
},
906903
),
907904
);
@@ -1081,11 +1078,8 @@ class DefaultAssetPickerBuilderDelegate
10811078
// 但通过 `File` 读取的文件对象仍然存在,使得返回的数据为空。
10821079
if (data != null) {
10831080
return Image.memory(data, fit: BoxFit.cover);
1084-
} else {
1085-
return ColoredBox(
1086-
color: theme.colorScheme.primary.withOpacity(0.12),
1087-
);
10881081
}
1082+
return ColoredBox(color: theme.colorScheme.primary.withOpacity(0.12));
10891083
}
10901084

10911085
return Material(
@@ -1139,14 +1133,13 @@ class DefaultAssetPickerBuilderDelegate
11391133
selector: (_, DefaultAssetPickerProvider p) =>
11401134
p.currentPathEntity,
11411135
builder: (_, AssetPathEntity? currentPathEntity, __) {
1142-
if (currentPathEntity != pathEntity) {
1143-
return const SizedBox.shrink();
1144-
} else {
1136+
if (currentPathEntity == pathEntity) {
11451137
return AspectRatio(
11461138
aspectRatio: 1.0,
11471139
child: Icon(Icons.check, color: themeColor, size: 26.0),
11481140
);
11491141
}
1142+
return const SizedBox.shrink();
11501143
},
11511144
),
11521145
],
@@ -1259,14 +1252,14 @@ class DefaultAssetPickerBuilderDelegate
12591252
onTap: () {
12601253
if (selected) {
12611254
provider.unSelectAsset(asset);
1262-
} else {
1263-
if (isSingleAssetMode) {
1264-
provider.selectedAssets.clear();
1265-
}
1266-
provider.selectAsset(asset);
1267-
if (isSingleAssetMode && !isPreviewEnabled) {
1268-
Navigator.of(context).pop(provider.selectedAssets);
1269-
}
1255+
return;
1256+
}
1257+
if (isSingleAssetMode) {
1258+
provider.selectedAssets.clear();
1259+
}
1260+
provider.selectAsset(asset);
1261+
if (isSingleAssetMode && !isPreviewEnabled) {
1262+
Navigator.of(context).pop(provider.selectedAssets);
12701263
}
12711264
},
12721265
child: Container(

lib/src/delegates/asset_picker_viewer_builder_delegate.dart

Lines changed: 10 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -639,12 +639,12 @@ class DefaultAssetPickerViewerBuilderDelegate
639639
}
640640
if (provider!.isSelectedNotEmpty) {
641641
Navigator.of(context).pop(provider.currentlySelectedAssets);
642-
} else {
643-
selectAsset(currentAsset);
644-
Navigator.of(context).pop(
645-
selectedAssets ?? <AssetEntity>[currentAsset],
646-
);
642+
return;
647643
}
644+
selectAsset(currentAsset);
645+
Navigator.of(context).pop(
646+
selectedAssets ?? <AssetEntity>[currentAsset],
647+
);
648648
},
649649
materialTapTargetSize: MaterialTapTargetSize.shrinkWrap,
650650
);
@@ -663,9 +663,9 @@ class DefaultAssetPickerViewerBuilderDelegate
663663
onTap: () {
664664
if (isSelected) {
665665
unSelectAsset(asset);
666-
} else {
667-
selectAsset(asset);
666+
return;
668667
}
668+
selectAsset(asset);
669669
},
670670
child: AnimatedContainer(
671671
duration: kThemeAnimationDuration,
@@ -704,9 +704,9 @@ class DefaultAssetPickerViewerBuilderDelegate
704704
onChanged: (bool? value) {
705705
if (isSelected) {
706706
unSelectAsset(asset);
707-
} else {
708-
selectAsset(asset);
707+
return;
709708
}
709+
selectAsset(asset);
710710
},
711711
materialTapTargetSize: MaterialTapTargetSize.shrinkWrap,
712712
);
@@ -737,9 +737,8 @@ class DefaultAssetPickerViewerBuilderDelegate
737737
currentlySelectedAssets.contains(asset);
738738
if (isAppleOS) {
739739
return _appleOSSelectButton(isSelected, asset);
740-
} else {
741-
return _androidSelectButton(isSelected, asset);
742740
}
741+
return _androidSelectButton(isSelected, asset);
743742
},
744743
),
745744
);

lib/src/provider/asset_picker_provider.dart

Lines changed: 4 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -355,12 +355,11 @@ class DefaultAssetPickerProvider
355355
.toList();
356356
if (assets.isNotEmpty && currentAssets.contains(assets[0])) {
357357
return;
358-
} else {
359-
final List<AssetEntity> tempList = <AssetEntity>[];
360-
tempList.addAll(_currentAssets);
361-
tempList.addAll(assets);
362-
currentAssets = tempList;
363358
}
359+
final List<AssetEntity> tempList = <AssetEntity>[];
360+
tempList.addAll(_currentAssets);
361+
tempList.addAll(assets);
362+
currentAssets = tempList;
364363
}
365364

366365
@override

lib/src/widget/asset_picker.dart

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -118,9 +118,8 @@ class AssetPicker<A, P> extends StatelessWidget {
118118
),
119119
);
120120
return result;
121-
} else {
122-
return null;
123121
}
122+
return null;
124123
} catch (e) {
125124
realDebugPrint('Error when calling assets picker: $e');
126125
return null;

0 commit comments

Comments
 (0)