⚡️ Improve onChangingSelected in AssetPickerViewerBuilderDelegate (#332)

Author: AlexV525

CHANGELOG.md

@@ -4,6 +4,13 @@ that can be found in the LICENSE file. -->
 
 # Changelog
 
+## 7.3.2
+
+### Improvements
+
+- Improve `onChangingSelected` in `AssetPickerViewerBuilderDelegate`. (#332)
+- Fix typo in `README.md`. (#333)
+
 ## 7.3.1
 
 ### Improvements

example/pubspec.yaml

@@ -1,6 +1,6 @@
 name: wechat_assets_picker_demo
 description: The demo project for the wechat_assets_picker package.
-version: 7.3.1+18
+version: 7.3.2+19
 publish_to: none
 
 environment:
@@ -17,7 +17,6 @@ dependencies:
     path: ../
   wechat_camera_picker: ^3.2.0
 
-  meta: ^1.7.0
   package_info_plus: ^1.4.2
   path: ^1.8.0
   path_provider: ^2.0.8

lib/src/delegates/asset_picker_viewer_builder_delegate.dart

@@ -240,9 +240,7 @@ abstract class AssetPickerViewerBuilderDelegate<Asset, Path> {
     if (!isSelectedPreviewing) {
       selectedAssets?.remove(entity);
     }
-    if (selectedCount != selectedNotifier.value) {
-      selectedNotifier.value = selectedCount;
-    }
+    selectedNotifier.value = selectedCount;
   }
 
   void selectAsset(Asset entity) {
@@ -254,12 +252,10 @@ abstract class AssetPickerViewerBuilderDelegate<Asset, Path> {
     if (!isSelectedPreviewing) {
       selectedAssets?.add(entity);
     }
-    if (selectedCount != selectedNotifier.value) {
-      selectedNotifier.value = selectedCount;
-    }
+    selectedNotifier.value = selectedCount;
   }
 
-  Future<void> onChangingSelected(
+  Future<bool> onChangingSelected(
     BuildContext context,
     Asset asset,
     bool isSelected,
@@ -270,13 +266,14 @@ abstract class AssetPickerViewerBuilderDelegate<Asset, Path> {
       isSelected,
     );
     if (selectPredicateResult == false) {
-      return;
+      return false;
     }
     if (isSelected) {
       unSelectAsset(asset);
-      return;
+    } else {
+      selectAsset(asset);
     }
-    selectAsset(asset);
+    return true;
   }
 
   /// Method to switch [isDisplayingDetail].
@@ -806,7 +803,7 @@ class DefaultAssetPickerViewerBuilderDelegate
             shape: RoundedRectangleBorder(
               borderRadius: BorderRadius.circular(3.0),
             ),
-            onPressed: () {
+            onPressed: () async {
               if (isWeChatMoment && hasVideo) {
                 Navigator.of(context).pop(<AssetEntity>[currentAsset]);
                 return;
@@ -815,10 +812,11 @@ class DefaultAssetPickerViewerBuilderDelegate
                 Navigator.of(context).pop(provider.currentlySelectedAssets);
                 return;
               }
-              selectAsset(currentAsset);
-              Navigator.of(context).pop(
-                selectedAssets ?? <AssetEntity>[currentAsset],
-              );
+              if (await onChangingSelected(context, currentAsset, false)) {
+                Navigator.of(context).pop(
+                  selectedAssets ?? <AssetEntity>[currentAsset],
+                );
+              }
             },
             materialTapTargetSize: MaterialTapTargetSize.shrinkWrap,
             child: ScaleText(

pubspec.yaml

@@ -1,6 +1,6 @@
 name: wechat_assets_picker
 description: An audio/video/image picker in pure Dart which is the same with WeChat, support multi picking.
-version: 7.3.1
+version: 7.3.2
 homepage: https://github.com/fluttercandies/flutter_wechat_assets_picker
 
 environment: