Skip to content

Commit da5092c

Browse files
committed
🎨 Update code through new analyzer options.
1 parent af710e4 commit da5092c

File tree

5 files changed

+12
-13
lines changed

5 files changed

+12
-13
lines changed

analysis_options.yaml

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -59,7 +59,7 @@ linter:
5959
- avoid_classes_with_only_static_members
6060
# - avoid_double_and_int_checks # only useful when targeting JS runtime
6161
- avoid_empty_else
62-
# - avoid_equals_and_hash_code_on_mutable_classes
62+
- avoid_equals_and_hash_code_on_mutable_classes
6363
- avoid_field_initializers_in_const_classes
6464
- avoid_function_literals_in_foreach_calls
6565
# - avoid_implementing_value_types # not yet tested
@@ -175,7 +175,7 @@ linter:
175175
- sort_constructors_first
176176
- sort_pub_dependencies
177177
- sort_unnamed_constructors_first
178-
# - test_types_in_equals
178+
- test_types_in_equals
179179
- throw_in_finally
180180
# - type_annotate_public_apis # subset of always_specify_types
181181
- type_init_formals
@@ -192,7 +192,7 @@ linter:
192192
- unnecessary_overrides
193193
- unnecessary_parenthesis
194194
- unnecessary_statements
195-
# - unnecessary_string_interpolations
195+
- unnecessary_string_interpolations
196196
- unnecessary_this
197197
- unrelated_type_equality_checks
198198
# - unsafe_html # not yet tested

lib/src/constants/text_delegate.dart

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -101,9 +101,9 @@ class DefaultTextDelegate implements TextDelegate {
101101
@override
102102
String durationIndicatorBuilder(Duration duration) {
103103
const String separator = ':';
104-
final String minute = '${(duration.inMinutes).toString().padLeft(2, '0')}';
104+
final String minute = duration.inMinutes.toString().padLeft(2, '0');
105105
final String second =
106-
'${((duration - Duration(minutes: duration.inMinutes)).inSeconds).toString().padLeft(2, '0')}';
106+
((duration - Duration(minutes: duration.inMinutes)).inSeconds).toString().padLeft(2, '0');
107107
return '$minute$separator$second';
108108
}
109109
}

lib/src/provider/asset_entity_image_provider.dart

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -9,8 +9,9 @@ import 'package:flutter/material.dart';
99
import 'package:flutter/foundation.dart';
1010
import 'package:photo_manager/photo_manager.dart';
1111

12+
@immutable
1213
class AssetEntityImageProvider extends ImageProvider<AssetEntityImageProvider> {
13-
AssetEntityImageProvider(
14+
const AssetEntityImageProvider(
1415
this.entity, {
1516
this.scale = 1.0,
1617
this.thumbSize = 200,
@@ -33,9 +34,7 @@ class AssetEntityImageProvider extends ImageProvider<AssetEntityImageProvider> {
3334

3435
/// File type for the image asset, use it for some special type detection.
3536
/// 图片资源的类型,用于某些特殊类型的判断
36-
ImageFileType _imageFileType;
37-
38-
ImageFileType get imageFileType => _imageFileType ?? _getType();
37+
ImageFileType get imageFileType => _getType();
3938

4039
@override
4140
ImageStreamCompleter load(

lib/src/widget/asset_picker.dart

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -235,7 +235,7 @@ class AssetPicker extends StatelessWidget {
235235
if (provider.currentPathEntity != null)
236236
Flexible(
237237
child: Text(
238-
'${provider.currentPathEntity.name}',
238+
provider.currentPathEntity.name ?? '',
239239
style: const TextStyle(
240240
fontSize: 18.0,
241241
fontWeight: FontWeight.normal,
@@ -329,7 +329,7 @@ class AssetPicker extends StatelessWidget {
329329
child: Padding(
330330
padding: const EdgeInsets.only(right: 10.0),
331331
child: Text(
332-
'${pathEntity.name}',
332+
pathEntity.name ?? '',
333333
style: const TextStyle(fontSize: 18.0),
334334
maxLines: 1,
335335
overflow: TextOverflow.ellipsis,

lib/src/widget/builder/audio_page_builder.dart

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -89,7 +89,7 @@ class _AudioPageBuilderState extends State<AudioPageBuilder> {
8989
/// 标题组件
9090
Widget get titleWidget => Text(
9191
widget.asset.title,
92-
style: TextStyle(
92+
style: const TextStyle(
9393
fontSize: 20.0,
9494
fontWeight: FontWeight.normal,
9595
),
@@ -137,7 +137,7 @@ class _AudioPageBuilderState extends State<AudioPageBuilder> {
137137
'${Constants.textDelegate.durationIndicatorBuilder(data.data)}'
138138
' / '
139139
'${Constants.textDelegate.durationIndicatorBuilder(assetDuration)}',
140-
style: TextStyle(
140+
style: const TextStyle(
141141
fontSize: 20.0,
142142
fontWeight: FontWeight.normal,
143143
),

0 commit comments

Comments
 (0)