🐛 Fix semantics (#691)

Author: AlexV525

CHANGELOG.md

@@ -14,6 +14,10 @@ that can be found in the LICENSE file. -->
 - Improve how `MediaQuery` is being listened.
 - Stop enabling drag to select when `maxAssets == 1`.
 
+**Fixes**
+
+- Fix semantics with the close button.
+
 ## 9.5.1
 
 **Improvements**

example/lib/widgets/method_list_view.dart

@@ -40,9 +40,11 @@ class _MethodListViewState extends State<MethodListView> {
               width: 48,
               height: 48,
               child: Center(
-                child: Text(
-                  model.icon,
-                  style: const TextStyle(fontSize: 28.0),
+                child: ExcludeSemantics(
+                  child: Text(
+                    model.icon,
+                    style: const TextStyle(fontSize: 28.0),
+                  ),
                 ),
               ),
             ),

lib/src/delegates/asset_picker_builder_delegate.dart

@@ -696,14 +696,7 @@ abstract class AssetPickerBuilderDelegate<Asset, Path> {
           Navigator.maybeOf(context)?.maybePop();
         },
         tooltip: MaterialLocalizations.of(context).closeButtonTooltip,
-        icon: Icon(
-          Icons.close,
-          semanticLabel: switch (Theme.of(context).platform) {
-            TargetPlatform.android =>
-              MaterialLocalizations.of(context).closeButtonTooltip,
-            _ => null,
-          },
-        ),
+        icon: const Icon(Icons.close),
       ),
     );
   }
@@ -772,14 +765,17 @@ abstract class AssetPickerBuilderDelegate<Asset, Path> {
       ),
     );
 
-    final Widget accessLimitedButton = GestureDetector(
-      onTap: () {
-        permissionOverlayDisplay.value = false;
-      },
-      child: ScaleText(
-        textDelegate.accessLimitedAssets,
-        style: TextStyle(color: interactiveTextColor(context)),
-        semanticsLabel: semanticsTextDelegate.accessLimitedAssets,
+    final Widget accessLimitedButton = Semantics(
+      label: semanticsTextDelegate.accessLimitedAssets,
+      button: true,
+      child: GestureDetector(
+        onTap: () {
+          permissionOverlayDisplay.value = false;
+        },
+        child: ScaleText(
+          textDelegate.accessLimitedAssets,
+          style: TextStyle(color: interactiveTextColor(context)),
+        ),
       ),
     );
 

lib/src/delegates/asset_picker_viewer_builder_delegate.dart

@@ -733,14 +733,7 @@ class DefaultAssetPickerViewerBuilderDelegate
             Navigator.maybeOf(context)?.maybePop();
           },
           tooltip: MaterialLocalizations.of(context).backButtonTooltip,
-          icon: Icon(
-            Icons.arrow_back_ios_new,
-            semanticLabel: switch (Theme.of(context).platform) {
-              TargetPlatform.android =>
-                MaterialLocalizations.of(context).backButtonTooltip,
-              _ => null,
-            },
-          ),
+          icon: const Icon(Icons.arrow_back_ios_new),
         ),
       ),
       centerTitle: true,