From c12d5bfd95cb819cea7c7ee30240e3584b529ed2 Mon Sep 17 00:00:00 2001 From: nathannewyen Date: Wed, 3 Dec 2025 16:53:18 -0500 Subject: [PATCH 1/2] fix: add explicit white color to default subtitle text The default subtitle text in all control widgets (Cupertino, Material, and Material Desktop) did not specify an explicit text color. This could cause subtitles to be invisible on certain themes where the default text color is dark, as subtitles are rendered on a semi-transparent black background. This fix adds explicit `color: Colors.white` to ensure subtitle text is always visible regardless of the app's theme configuration. Addresses #914 --- lib/src/cupertino/cupertino_controls.dart | 5 ++++- lib/src/material/material_controls.dart | 5 ++++- lib/src/material/material_desktop_controls.dart | 5 ++++- 3 files changed, 12 insertions(+), 3 deletions(-) diff --git a/lib/src/cupertino/cupertino_controls.dart b/lib/src/cupertino/cupertino_controls.dart index 201f236f0..800998688 100644 --- a/lib/src/cupertino/cupertino_controls.dart +++ b/lib/src/cupertino/cupertino_controls.dart @@ -222,7 +222,10 @@ class _CupertinoControlsState extends State ), child: Text( currentSubtitle.first!.text.toString(), - style: const TextStyle(fontSize: 18), + style: const TextStyle( + fontSize: 18, + color: Colors.white, + ), textAlign: TextAlign.center, ), ), diff --git a/lib/src/material/material_controls.dart b/lib/src/material/material_controls.dart index 8d052dd75..46e69ad52 100644 --- a/lib/src/material/material_controls.dart +++ b/lib/src/material/material_controls.dart @@ -234,7 +234,10 @@ class _MaterialControlsState extends State ), child: Text( currentSubtitle.first!.text.toString(), - style: const TextStyle(fontSize: 18), + style: const TextStyle( + fontSize: 18, + color: Colors.white, + ), textAlign: TextAlign.center, ), ), diff --git a/lib/src/material/material_desktop_controls.dart b/lib/src/material/material_desktop_controls.dart index acdd4a8b0..37cb4360a 100644 --- a/lib/src/material/material_desktop_controls.dart +++ b/lib/src/material/material_desktop_controls.dart @@ -247,7 +247,10 @@ class _MaterialDesktopControlsState extends State ), child: Text( currentSubtitle.first!.text.toString(), - style: const TextStyle(fontSize: 18), + style: const TextStyle( + fontSize: 18, + color: Colors.white, + ), textAlign: TextAlign.center, ), ), From 180028db7fed76da40d93a54f8c41933527e71d6 Mon Sep 17 00:00:00 2001 From: nathannewyen Date: Wed, 3 Dec 2025 18:39:54 -0500 Subject: [PATCH 2/2] style: apply dart format to subtitle text color changes --- lib/src/cupertino/cupertino_controls.dart | 5 +---- lib/src/material/material_controls.dart | 5 +---- lib/src/material/material_desktop_controls.dart | 5 +---- 3 files changed, 3 insertions(+), 12 deletions(-) diff --git a/lib/src/cupertino/cupertino_controls.dart b/lib/src/cupertino/cupertino_controls.dart index 800998688..80b65e872 100644 --- a/lib/src/cupertino/cupertino_controls.dart +++ b/lib/src/cupertino/cupertino_controls.dart @@ -222,10 +222,7 @@ class _CupertinoControlsState extends State ), child: Text( currentSubtitle.first!.text.toString(), - style: const TextStyle( - fontSize: 18, - color: Colors.white, - ), + style: const TextStyle(fontSize: 18, color: Colors.white), textAlign: TextAlign.center, ), ), diff --git a/lib/src/material/material_controls.dart b/lib/src/material/material_controls.dart index 46e69ad52..cda9c7c74 100644 --- a/lib/src/material/material_controls.dart +++ b/lib/src/material/material_controls.dart @@ -234,10 +234,7 @@ class _MaterialControlsState extends State ), child: Text( currentSubtitle.first!.text.toString(), - style: const TextStyle( - fontSize: 18, - color: Colors.white, - ), + style: const TextStyle(fontSize: 18, color: Colors.white), textAlign: TextAlign.center, ), ), diff --git a/lib/src/material/material_desktop_controls.dart b/lib/src/material/material_desktop_controls.dart index 37cb4360a..edaf3f57b 100644 --- a/lib/src/material/material_desktop_controls.dart +++ b/lib/src/material/material_desktop_controls.dart @@ -247,10 +247,7 @@ class _MaterialDesktopControlsState extends State ), child: Text( currentSubtitle.first!.text.toString(), - style: const TextStyle( - fontSize: 18, - color: Colors.white, - ), + style: const TextStyle(fontSize: 18, color: Colors.white), textAlign: TextAlign.center, ), ),