Missing awaits corrupt project.pbxproj

[xShuusui]

ℹ️ Info

Version: 0.14.1 and 0.13.1

💬 Description

When running dart run flutter_launcher_icons to generate launcher icons for each of our flavors, the project.pbxproj file of iOS is frequently corrupted and the ASSETCATALOG_COMPILER_APPICON_NAME values for the different flavor targets are not set correctly.

This issue occurs due to asynchronous read and write operations on the project.pbxproj for each flavor that are not awaited correctly, leading to simultaneous execution. As a result, the file becomes incorrect and corrupted.

Related Issues:
#506
#550
#565

A pull request will be opened in the coming days to address this issue. Afterward, a decision can be made on whether to proceed with the fixed asynchronous approach or to use the synchronous approach suggested in PR #551.

[tmenyhart-vlabs]

There's an open PR that should resolve the issue.

The issue is because the following line in the ios.dart file:

flutter_launcher_icons/lib/ios.dart

Line 328 in 48d0b93

line.contains('ASSETCATALOG')) {

[dowski]

There's an open PR that should resolve the issue.

While the linked PR might solve a different issue, I think the original issue posted here is still valid. The unawaited async work that is spawned by this code has no guarantee that it will complete before the command line process terminates.

There are certainly race conditions that could allow partially written/corrupted files, as noted in the issue description.

[xShuusui]

Hey all sorry its been a while, thankfully more people have similar problems with this library.

@tmenyhart-vlabs This is another issue I totally agree with, but its not only related to line.contains('ASSETCATALOG') also currentConfig.startsWith('$flavor') matches multiple flavors in our case as some of our flavors start with the same prefix like project-style1 and project-style2.

As we also use flutter_flavorizr and these two libraries do not work well together as both can be used to generate icon directories with different naming schemes. We disabled the icon generation in the flavorizr and used it to override specific flavor build settings. Works like a charm:

ios:
  buildSettings:
    ASSETCATALOG_COMPILER_APPICON_NAME: AppIcon-$(ASSET_PREFIX)

@dowski But nevertheless this issue still exists I just did not really bothered anymore as in some configurations it worked for us surprisingly. Unfortunately this library is not that actively maintained anymore. Maye now is the time to address it again.

[xShuusui]

Already fixed it in my fork last year, but could be smarter to do it carefully from scratch.

Will also take a look at this old MR #297 to resolve others aswell.

[dowski]

Haha, I just forked and fixed it too. I know there's also the approach in #551 that you linked.

[xShuusui]

Perfect Haha, let me know when it's done, so i can take a look and also test it next week. 👍

[dowski]

I consider it done, modulo any review feedback.

[MarkOSullivan94]

Should be fixed now thanks to @dowski