Skip to content

Example Code-Definition in main.dart increases binary size when using custom FA #291

@Drackrath

Description

@Drackrath

Describe the bug
Using Custom FA, its required to modify the code and import the lib as an override. However:

  • I want to add the FA-Code to a repository, so changes can be made on the fly
  • The "example" and "test" code is useless overhead when not needed
  • example code is in the util\lib\main.dart in which it doesn't belong
  • util is needed to regenerate with the configurator.sh or .bat

To Reproduce

  • clone the repo INSIDE a repo into smth like third_party
  • delete "example" folder
  • get an error

Expected behavior

  • no error
  • slim FA version?

Version:

  • FA 10.12

Possible fix:

  • Modify util\lib\main.dart to pass variables so example is only run on demand
  • Modify the util\lib\main.dart to duplicate into \example, so \example is its own project and the configurator needs to be run inside there
  • Decouple example from base-code completely

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions