refactor(device_info_plus)!: remove serialNumber property (#3663)

Author: StanleyCocos

packages/device_info_plus/device_info_plus/android/src/main/kotlin/dev/fluttercommunity/plus/device_info/MethodCallHandlerImpl.kt

@@ -80,18 +80,6 @@ internal class MethodCallHandlerImpl(
             build["isLowRamDevice"] = memoryInfo.lowMemory
             build["physicalRamSize"] = memoryInfo.totalMem / 1048576L // Mb
             build["availableRamSize"] = memoryInfo.availMem / 1048576L // Mb
-
-            if (Build.VERSION.SDK_INT >= Build.VERSION_CODES.O) {
-                build["serialNumber"] = try {
-                    Build.getSerial()
-                } catch (ex: SecurityException) {
-                    Build.UNKNOWN
-                }
-            } else {
-                @Suppress("DEPRECATION")
-                build["serialNumber"] = Build.SERIAL
-            }
-
             result.success(build)
         } else {
             result.notImplemented()

packages/device_info_plus/device_info_plus/example/integration_test/device_info_plus_test.dart

@@ -111,7 +111,6 @@ void main() {
     expect(androidInfo.type, isNotNull);
     expect(androidInfo.isPhysicalDevice, isNotNull);
     expect(androidInfo.systemFeatures, isNotNull);
-    expect(androidInfo.serialNumber, isNotNull);
   }, skip: !Platform.isAndroid);
 
   testWidgets('Check all macos info values are available', ((

packages/device_info_plus/device_info_plus/example/lib/main.dart

@@ -112,7 +112,6 @@ class _MyAppState extends State<MyApp> {
       'freeDiskSize': build.freeDiskSize,
       'totalDiskSize': build.totalDiskSize,
       'systemFeatures': build.systemFeatures,
-      'serialNumber': build.serialNumber,
       'isLowRamDevice': build.isLowRamDevice,
       'physicalRamSize': build.physicalRamSize,
       'availableRamSize': build.availableRamSize,

packages/device_info_plus/device_info_plus/lib/src/model/android_device_info.dart

@@ -34,7 +34,6 @@ class AndroidDeviceInfo extends BaseDeviceInfo {
     required this.freeDiskSize,
     required this.totalDiskSize,
     required List<String> systemFeatures,
-    required this.serialNumber,
     required this.isLowRamDevice,
     required this.physicalRamSize,
     required this.availableRamSize,
@@ -151,12 +150,6 @@ class AndroidDeviceInfo extends BaseDeviceInfo {
   /// https://developer.android.com/reference/android/content/pm/PackageManager
   final List<String> systemFeatures;
 
-  /// Hardware serial number of the device, if available
-  ///
-  /// There are special restrictions on this identifier, more info here:
-  /// https://developer.android.com/reference/android/os/Build#getSerial()
-  final String serialNumber;
-
   /// `true` if the application is running on a low-RAM device, `false` otherwise.
   final bool isLowRamDevice;
 
@@ -199,7 +192,6 @@ class AndroidDeviceInfo extends BaseDeviceInfo {
       freeDiskSize: map['freeDiskSize'],
       totalDiskSize: map['totalDiskSize'],
       systemFeatures: _fromList(map['systemFeatures'] ?? []),
-      serialNumber: map['serialNumber'],
       isLowRamDevice: map['isLowRamDevice'],
       physicalRamSize: map['physicalRamSize'],
       availableRamSize: map['availableRamSize'],
@@ -232,7 +224,6 @@ class AndroidDeviceInfo extends BaseDeviceInfo {
     required int freeDiskSize,
     required int totalDiskSize,
     required List<String> systemFeatures,
-    required String serialNumber,
     required bool isLowRamDevice,
     required int physicalRamSize,
     required int availableRamSize,
@@ -269,7 +260,6 @@ class AndroidDeviceInfo extends BaseDeviceInfo {
       'freeDiskSize': freeDiskSize,
       'totalDiskSize': totalDiskSize,
       'systemFeatures': systemFeatures,
-      'serialNumber': serialNumber,
       'isLowRamDevice': isLowRamDevice,
       'physicalRamSize': physicalRamSize,
       'availableRamSize': availableRamSize,
@@ -300,7 +290,6 @@ class AndroidDeviceInfo extends BaseDeviceInfo {
       freeDiskSize: freeDiskSize,
       totalDiskSize: totalDiskSize,
       systemFeatures: _fromList(systemFeatures),
-      serialNumber: serialNumber,
       isLowRamDevice: isLowRamDevice,
       physicalRamSize: physicalRamSize,
       availableRamSize: availableRamSize,

packages/device_info_plus/device_info_plus/test/model/android_device_info_fake.dart

@@ -39,7 +39,6 @@ const _fakeAndroidDeviceInfo = <String, dynamic>{
   'version': _fakeAndroidBuildVersion,
   'supported64BitAbis': _fakeSupported64BitAbis,
   'supported32BitAbis': _fakeSupported32BitAbis,
-  'serialNumber': 'SERIAL',
   'isLowRamDevice': false,
   'physicalRamSize': 8192,
   'availableRamSize': 4096,

packages/device_info_plus/device_info_plus/test/model/android_device_info_test.dart

@@ -41,7 +41,6 @@ void main() {
       expect(androidDeviceInfo.version.codename, 'codename');
       expect(androidDeviceInfo.version.incremental, 'incremental');
       expect(androidDeviceInfo.version.securityPatch, 'securityPatch');
-      expect(androidDeviceInfo.serialNumber, 'SERIAL');
       expect(androidDeviceInfo.isLowRamDevice, false);
       expect(androidDeviceInfo.physicalRamSize, 8192);
       expect(androidDeviceInfo.availableRamSize, 4096);