Skip to content

Commit 3635a30

Browse files
authored
Revert "[Tool] [Windows] Output app path on build completion (flutter#122858)" (flutter#122926)
Revert "[Tool] [Windows] Output app path on build completion"
1 parent db5711b commit 3635a30

File tree

2 files changed

+0
-39
lines changed

2 files changed

+0
-39
lines changed

dev/devicelab/lib/tasks/run_tests.dart

Lines changed: 0 additions & 22 deletions
Original file line numberDiff line numberDiff line change
@@ -177,9 +177,6 @@ class WindowsRunOutputTest extends DesktopRunOutputTest {
177177
r'Building Windows application\.\.\.\s*\d+(\.\d+)?(ms|s)',
178178
multiLine: true,
179179
);
180-
static final RegExp _builtOutput = RegExp(
181-
r'Built build\\windows\\runner\\(Debug|Release)\\\w+\.exe( \(\d+(\.\d+)?MB\))?\.',
182-
);
183180

184181
@override
185182
void verifyBuildOutput(List<String> stdout) {
@@ -188,25 +185,6 @@ class WindowsRunOutputTest extends DesktopRunOutputTest {
188185
_buildOutput.hasMatch,
189186
'Building Windows application...',
190187
);
191-
192-
final String buildMode = release ? 'Release' : 'Debug';
193-
_findNextMatcherInList(
194-
stdout,
195-
(String line) {
196-
if (!_builtOutput.hasMatch(line) || !line.contains(buildMode)) {
197-
return false;
198-
}
199-
200-
// Size information is only included in release builds.
201-
final bool hasSize = line.contains('MB).');
202-
if (release != hasSize) {
203-
return false;
204-
}
205-
206-
return true;
207-
},
208-
'Built build\\windows\\runner\\$buildMode\\app.exe',
209-
);
210188
}
211189
}
212190

packages/flutter_tools/lib/src/windows/build_windows.dart

Lines changed: 0 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,6 @@ import '../base/common.dart';
88
import '../base/file_system.dart';
99
import '../base/logger.dart';
1010
import '../base/project_migrator.dart';
11-
import '../base/terminal.dart';
1211
import '../base/utils.dart';
1312
import '../build_info.dart';
1413
import '../cache.dart';
@@ -93,22 +92,6 @@ Future<void> buildWindows(WindowsProject windowsProject, BuildInfo buildInfo, {
9392
} finally {
9493
status.stop();
9594
}
96-
97-
final File appFile = buildDirectory
98-
.childDirectory('runner')
99-
.childDirectory(sentenceCase(buildModeName))
100-
.childFile('${windowsProject.parent.manifest.appName}.exe');
101-
if (appFile.existsSync()) {
102-
final String appSize = (buildInfo.mode == BuildMode.debug)
103-
? '' // Don't display the size when building a debug variant.
104-
: ' (${getSizeAsMB(appFile.lengthSync())})';
105-
globals.logger.printStatus(
106-
'${globals.logger.terminal.successMark} '
107-
'Built ${globals.fs.path.relative(appFile.path)}$appSize.',
108-
color: TerminalColor.green,
109-
);
110-
}
111-
11295
if (buildInfo.codeSizeDirectory != null && sizeAnalyzer != null) {
11396
final String arch = getNameForTargetPlatform(TargetPlatform.windows_x64);
11497
final File codeSizeFile = globals.fs.directory(buildInfo.codeSizeDirectory)

0 commit comments

Comments
 (0)