Skip to content

Commit 500684c

Browse files
authored
[Impeller] Log glCheckFrameBufferStatus output when it fails in blit pass. (flutter#172592)
We haven't been able to reproduce flutter#169203. We should log the error so that future repros are more useful. We've already started doing this for other usages (flutter/engine#46692).
1 parent 0e7da1d commit 500684c

File tree

1 file changed

+5
-3
lines changed

1 file changed

+5
-3
lines changed

engine/src/flutter/impeller/renderer/backend/gles/blit_command_gles.cc

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -5,11 +5,11 @@
55
#include "impeller/renderer/backend/gles/blit_command_gles.h"
66

77
#include "flutter/fml/closure.h"
8-
#include "fml/trace_event.h"
98
#include "impeller/base/validation.h"
109
#include "impeller/core/formats.h"
1110
#include "impeller/geometry/point.h"
1211
#include "impeller/renderer/backend/gles/device_buffer_gles.h"
12+
#include "impeller/renderer/backend/gles/formats_gles.h"
1313
#include "impeller/renderer/backend/gles/reactor_gles.h"
1414
#include "impeller/renderer/backend/gles/texture_gles.h"
1515

@@ -74,8 +74,10 @@ static std::optional<GLuint> ConfigureFBO(
7474
return std::nullopt;
7575
}
7676

77-
if (gl.CheckFramebufferStatus(fbo_type) != GL_FRAMEBUFFER_COMPLETE) {
78-
VALIDATION_LOG << "Could not create a complete framebuffer.";
77+
GLenum status = gl.CheckFramebufferStatus(fbo_type);
78+
if (status != GL_FRAMEBUFFER_COMPLETE) {
79+
VALIDATION_LOG << "Could not create a complete framebuffer: "
80+
<< DebugToFramebufferError(status);
7981
DeleteFBO(gl, fbo, fbo_type);
8082
return std::nullopt;
8183
}

0 commit comments

Comments
 (0)