Revert the preview-device feature, tests, and code that only existed for it. (flutter#162835)

Closes flutter#162693.

Fortunately due to the power of `git`, it will live forever 🫡

Author: matanlurey

packages/flutter_tools/lib/executable.dart

@@ -187,11 +187,9 @@ List<FlutterCommand> generateCommands({required bool verboseHelp, required bool
         fileSystem: globals.fs,
       ),
       BuildCommand(
-        artifacts: globals.artifacts!,
         fileSystem: globals.fs,
         buildSystem: globals.buildSystem,
         osUtils: globals.os,
-        processUtils: globals.processUtils,
         verboseHelp: verboseHelp,
         androidSdk: globals.androidSdk,
         logger: globals.logger,

packages/flutter_tools/lib/src/artifacts.dart

@@ -73,9 +73,6 @@ enum Artifact {
 
   /// The location of file generators.
   flutterToolsFileGenerators,
-
-  /// Pre-built desktop debug app.
-  flutterPreviewDevice,
 }
 
 /// A subset of [Artifact]s that are platform and build mode independent
@@ -241,8 +238,6 @@ String? _artifactToFileName(Artifact artifact, Platform hostPlatform, [BuildMode
       return 'const_finder.dart.snapshot';
     case Artifact.flutterToolsFileGenerators:
       return '';
-    case Artifact.flutterPreviewDevice:
-      return 'flutter_preview$exe';
   }
 }
 
@@ -672,7 +667,6 @@ class CachedArtifacts implements Artifacts {
       case Artifact.windowsCppClientWrapper:
       case Artifact.windowsDesktopPath:
       case Artifact.flutterToolsFileGenerators:
-      case Artifact.flutterPreviewDevice:
         return _getHostArtifactPath(artifact, platform, mode);
     }
   }
@@ -724,7 +718,6 @@ class CachedArtifacts implements Artifacts {
       case Artifact.windowsCppClientWrapper:
       case Artifact.windowsDesktopPath:
       case Artifact.flutterToolsFileGenerators:
-      case Artifact.flutterPreviewDevice:
         return _getHostArtifactPath(artifact, platform, mode);
     }
   }
@@ -771,7 +764,6 @@ class CachedArtifacts implements Artifacts {
       case Artifact.windowsCppClientWrapper:
       case Artifact.windowsDesktopPath:
       case Artifact.flutterToolsFileGenerators:
-      case Artifact.flutterPreviewDevice:
         return _getHostArtifactPath(artifact, platform, mode);
     }
   }
@@ -823,7 +815,6 @@ class CachedArtifacts implements Artifacts {
       case Artifact.windowsCppClientWrapper:
       case Artifact.windowsDesktopPath:
       case Artifact.flutterToolsFileGenerators:
-      case Artifact.flutterPreviewDevice:
         return _getHostArtifactPath(artifact, platform, mode);
     }
   }
@@ -955,9 +946,6 @@ class CachedArtifacts implements Artifacts {
         throw StateError('Artifact $artifact not available for platform $platform.');
       case Artifact.flutterToolsFileGenerators:
         return _getFileGeneratorsPath();
-      case Artifact.flutterPreviewDevice:
-        assert(platform == TargetPlatform.windows_x64);
-        return _cache.getArtifactDirectory('flutter_preview').childFile('flutter_preview.exe').path;
     }
   }
 
@@ -1442,13 +1430,6 @@ class CachedLocalEngineArtifacts implements Artifacts {
         return _fileSystem.path.join(_getDartSdkPath(), 'bin', 'snapshots', artifactFileName);
       case Artifact.flutterToolsFileGenerators:
         return _getFileGeneratorsPath();
-      case Artifact.flutterPreviewDevice:
-        return _backupCache.getArtifactPath(
-          artifact,
-          platform: platform,
-          mode: mode,
-          environmentType: environmentType,
-        );
     }
   }
 
@@ -1624,7 +1605,6 @@ class CachedLocalWebSdkArtifacts implements Artifacts {
         case Artifact.fontSubset:
         case Artifact.constFinder:
         case Artifact.flutterToolsFileGenerators:
-        case Artifact.flutterPreviewDevice:
           break;
       }
     }

packages/flutter_tools/lib/src/commands/build.dart

@@ -5,14 +5,11 @@
 import 'package:meta/meta.dart';
 
 import '../android/android_sdk.dart';
-import '../artifacts.dart';
 import '../base/file_system.dart';
 import '../base/logger.dart';
 import '../base/os.dart';
-import '../base/process.dart';
 import '../build_info.dart';
 import '../build_system/build_system.dart';
-import '../cache.dart';
 import '../commands/build_linux.dart';
 import '../commands/build_macos.dart';
 import '../commands/build_windows.dart';
@@ -24,18 +21,15 @@ import 'build_bundle.dart';
 import 'build_ios.dart';
 import 'build_ios_framework.dart';
 import 'build_macos_framework.dart';
-import 'build_preview.dart';
 import 'build_web.dart';
 
 class BuildCommand extends FlutterCommand {
   BuildCommand({
-    required Artifacts artifacts,
     required FileSystem fileSystem,
     required BuildSystem buildSystem,
     required OperatingSystemUtils osUtils,
     required Logger logger,
     required AndroidSdk? androidSdk,
-    required ProcessUtils processUtils,
     bool verboseHelp = false,
   }) {
     _addSubcommand(
@@ -71,16 +65,6 @@ class BuildCommand extends FlutterCommand {
     _addSubcommand(
       BuildWindowsCommand(logger: logger, operatingSystemUtils: osUtils, verboseHelp: verboseHelp),
     );
-    _addSubcommand(
-      BuildPreviewCommand(
-        artifacts: artifacts,
-        flutterRoot: Cache.flutterRoot!,
-        fs: fileSystem,
-        logger: logger,
-        processUtils: processUtils,
-        verboseHelp: verboseHelp,
-      ),
-    );
   }
 
   void _addSubcommand(BuildSubCommand command) {

packages/flutter_tools/lib/src/commands/build_preview.dart

@@ -585,23 +585,6 @@ class DaemonDomain extends Domain {
                 'fixCode': _ReasonCode.config.name,
               });
             }
-          case PlatformType.windowsPreview:
-            // TODO(fujino): detect if there any plugins with native code
-            if (!featureFlags.isPreviewDeviceEnabled) {
-              reasons.add(<String, Object>{
-                'reasonText': 'the Preview Device feature is not enabled',
-                'fixText': 'Run "flutter config --enable-flutter-preview',
-                'fixCode': _ReasonCode.config.name,
-              });
-            }
-            if (!supportedPlatforms.contains(SupportedPlatform.windows)) {
-              reasons.add(<String, Object>{
-                'reasonText': 'the Windows platform is not enabled for this project',
-                'fixText':
-                    'Run "flutter create --platforms=windows ." in your application directory',
-                'fixCode': _ReasonCode.create.name,
-              });
-            }
         }
 
         if (reasons.isEmpty) {

packages/flutter_tools/lib/src/commands/daemon.dart

@@ -253,7 +253,6 @@ final class WidgetPreviewStartCommand extends WidgetPreviewSubCommandBase with C
       linuxPlatform: platform.isLinux,
       macOSPlatform: platform.isMacOS,
       windowsPlatform: platform.isWindows,
-      allowedPlugins: const <String>[],
     );
 
     // Generate initial package_config.json, otherwise the build will fail.

packages/flutter_tools/lib/src/commands/widget_preview.dart

@@ -50,8 +50,7 @@ enum PlatformType {
   macos,
   windows,
   fuchsia,
-  custom,
-  windowsPreview;
+  custom;
 
   @override
   String toString() => name;

packages/flutter_tools/lib/src/device.dart

@@ -48,9 +48,6 @@ abstract class FeatureFlags {
   /// Whether native assets compilation and bundling is enabled.
   bool get isNativeAssetsEnabled => false;
 
-  /// Whether native assets compilation and bundling is enabled.
-  bool get isPreviewDeviceEnabled => true;
-
   /// Whether Swift Package Manager dependency management is enabled.
   bool get isSwiftPackageManagerEnabled => false;
 
@@ -75,7 +72,6 @@ const List<Feature> allFeatures = <Feature>[
   flutterCustomDevicesFeature,
   cliAnimation,
   nativeAssets,
-  previewDevice,
   swiftPackageManager,
   explicitPackageDependencies,
 ];
@@ -159,15 +155,6 @@ const Feature nativeAssets = Feature(
   master: FeatureChannelSetting(available: true),
 );
 
-/// Enable Flutter preview prebuilt device.
-const Feature previewDevice = Feature(
-  name: 'Flutter preview prebuilt device',
-  configSetting: 'enable-flutter-preview',
-  environmentOverride: 'FLUTTER_PREVIEW_DEVICE',
-  master: FeatureChannelSetting(available: true),
-  beta: FeatureChannelSetting(available: true),
-);
-
 /// Enable Swift Package Manager as a darwin dependency manager.
 const Feature swiftPackageManager = Feature(
   name: 'support for Swift Package Manager for iOS and macOS',

packages/flutter_tools/lib/src/features.dart

@@ -25,7 +25,6 @@ import 'macos/macos_ipad_device.dart';
 import 'macos/macos_workflow.dart';
 import 'macos/xcdevice.dart';
 import 'native_assets.dart';
-import 'preview_device.dart';
 import 'tester/flutter_tester.dart';
 import 'version.dart';
 import 'web/web_device.dart';
@@ -94,14 +93,6 @@ class FlutterDeviceManager extends DeviceManager {
            fileSystem: fileSystem,
            operatingSystemUtils: operatingSystemUtils,
          ),
-         PreviewDeviceDiscovery(
-           platform: platform,
-           artifacts: artifacts,
-           fileSystem: fileSystem,
-           logger: logger,
-           processManager: processManager,
-           featureFlags: featureFlags,
-         ),
          LinuxDevices(
            platform: platform,
            featureFlags: featureFlags,

packages/flutter_tools/lib/src/flutter_device_manager.dart

@@ -55,9 +55,6 @@ class FlutterFeatureFlags implements FeatureFlags {
   @override
   bool get isNativeAssetsEnabled => isEnabled(nativeAssets);
 
-  @override
-  bool get isPreviewDeviceEnabled => isEnabled(previewDevice);
-
   @override
   bool get isSwiftPackageManagerEnabled => isEnabled(swiftPackageManager);