Skip to content

Commit cdd1ae9

Browse files
Check the realm file in its own shard. (flutter#137160)
This way, it is easier to differentiate between a real failure in the tools tests vs. just the realm check that blocks the merge.
1 parent f98b557 commit cdd1ae9

File tree

3 files changed

+24
-0
lines changed

3 files changed

+24
-0
lines changed

.ci.yaml

Lines changed: 15 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1099,6 +1099,21 @@ targets:
10991099
- bin/**
11001100
- .ci.yaml
11011101

1102+
- name: Linux realm_checker
1103+
bringup: true
1104+
recipe: flutter/flutter_drone
1105+
timeout: 60
1106+
properties:
1107+
add_recipes_cq: "true"
1108+
shard: realm_checker
1109+
tags: >
1110+
["framework", "hostonly", "shard", "linux"]
1111+
runIf:
1112+
- dev/**
1113+
- packages/flutter_tools/**
1114+
- bin/**
1115+
- .ci.yaml
1116+
11021117
- name: Linux web_benchmarks_canvaskit
11031118
recipe: devicelab/devicelab_drone
11041119
presubmit: false

TESTOWNERS

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -340,3 +340,4 @@
340340
# web_long_running_tests @yjbanov @flutter/web
341341
# web_tests @yjbanov @flutter/web
342342
# web_tool_tests @eliasyishak @flutter/tool
343+
# realm_checker @jacksongardner @flutter/tool

dev/bots/test.dart

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -262,6 +262,7 @@ Future<void> main(List<String> args) async {
262262
'web_long_running_tests': _runWebLongRunningTests,
263263
'flutter_plugins': _runFlutterPackagesTests,
264264
'skp_generator': _runSkpGeneratorTests,
265+
'realm_checker': _runRealmCheckerTest,
265266
kTestHarnessShardName: _runTestHarnessTests, // Used for testing this script; also run as part of SHARD=framework_tests, SUBSHARD=misc.
266267
});
267268
} catch (error, stackTrace) {
@@ -1568,6 +1569,13 @@ Future<void> _runSkpGeneratorTests() async {
15681569
);
15691570
}
15701571

1572+
Future<void> _runRealmCheckerTest() async {
1573+
final String engineRealm = File(engineRealmFile).readAsStringSync().trim();
1574+
if (engineRealm.isNotEmpty) {
1575+
foundError(<String>['The checked-in engine.realm file must be empty.']);
1576+
}
1577+
}
1578+
15711579
// The `chromedriver` process created by this test.
15721580
//
15731581
// If an existing chromedriver is already available on port 4444, the existing

0 commit comments

Comments
 (0)