Skip to content

Commit f50b671

Browse files
authored
Split Linux docs_publish into Linux docs_generate_release (flutter#169793)
Towards flutter#168913. This will need to be cherry-picked into the stable and beta release candidate branches.
1 parent b136021 commit f50b671

File tree

2 files changed

+67
-36
lines changed

2 files changed

+67
-36
lines changed

.ci.yaml

Lines changed: 66 additions & 35 deletions
Original file line numberDiff line numberDiff line change
@@ -546,18 +546,45 @@ targets:
546546
# to GCS", and conditionally on the "master" channel will also deploy the docs
547547
# to Firebase (https://main-api.flutter.dev/).
548548
#
549-
# See "Linux docs_deploy_stable" for how the docs are deployed to stable API.
549+
# See "Linux docs_generate_release" for how docs are built (but not published)
550+
# and "Linux docs_deploy_stable" for how docs deployed for the stable branch
551+
# (we do not deploy docs for beta).
550552
- name: Linux docs_publish
551553
recipe: flutter/docs
552554
presubmit: false
553555
backfill: false
554-
# This means "allow this to be scheduled by the release/release_builder"
555-
# recipe. Normally we'd use "schedule: true", but that *also* means "do not
556-
# run this in normal presubmit/postsubmit", and we do want it to run in
557-
# postsubmit for the "master" channel. Sorry.
558-
#
559-
# See https://github.com/flutter/flutter/issues/168709 for details.
560-
schedule_during_release_override: true
556+
enabled_branches:
557+
- master
558+
timeout: 60
559+
dimensions:
560+
os: "Linux"
561+
properties:
562+
cores: "32"
563+
dependencies: >-
564+
[
565+
{"dependency": "dashing", "version": "0.4.0"},
566+
{"dependency": "firebase", "version": "v11.0.1"}
567+
]
568+
tags: >
569+
["framework", "hostonly", "linux"]
570+
validation: docs
571+
validation_name: Docs
572+
firebase_project: main-docs-flutter-prod
573+
release_ref: refs/heads/master
574+
drone_dimensions:
575+
- os=Linux
576+
577+
- name: Linux docs_generate_release
578+
recipe: flutter/docs
579+
# TODO(matanlurey): This has no effect, is used to allow creating a builder.
580+
# Remove in the next PR.
581+
# https://github.com/flutter/flutter/issues/168913
582+
bringup: true
583+
scheduler: release
584+
presubmit: false
585+
postsubmit: false
586+
enabled_branches:
587+
- flutter-\d+\.\d+-candidate\.\d+
561588
timeout: 60
562589
dimensions:
563590
os: "Linux"
@@ -572,11 +599,42 @@ targets:
572599
["framework", "hostonly", "linux"]
573600
validation: docs
574601
validation_name: Docs
602+
# TODO(matanlurey): Neither of these properties are actually used, since
603+
# the branch name is not "master", but if they are removed, the recipe
604+
# will fail. See https://github.com/flutter/flutter/issues/169108.
575605
firebase_project: main-docs-flutter-prod
576606
release_ref: refs/heads/master
577607
drone_dimensions:
578608
- os=Linux
579609

610+
611+
# This step runs on the release channel "stable", after the same commit SHA
612+
# has been run and built by Linux flutter_release_builder as part of a release
613+
# candidate branch (i.e. /flutter-\d+\.\d+-candidate\.\d+/) in the previous
614+
# target, "Linux docs_generate_release".
615+
- name: Linux docs_deploy_stable
616+
recipe: flutter/docs
617+
scheduler: release
618+
presubmit: false
619+
postsubmit: false
620+
enabled_branches:
621+
- stable
622+
timeout: 60
623+
properties:
624+
cores: "32"
625+
dependencies: >-
626+
[
627+
{"dependency": "dashing", "version": "0.4.0"},
628+
{"dependency": "firebase", "version": "v11.0.1"}
629+
]
630+
tags: >
631+
["framework", "hostonly", "linux"]
632+
validation: docs_deploy
633+
validation_name: Docs_deploy
634+
firebase_project: docs-flutter-dev
635+
drone_dimensions:
636+
- os=Linux
637+
580638
- name: Linux docs_test
581639
recipe: flutter/flutter_drone
582640
timeout: 30
@@ -6960,30 +7018,3 @@ targets:
69607018
["framework", "hostonly", "shard", "windows"]
69617019
drone_dimensions:
69627020
- os=Windows
6963-
6964-
# This step runs on the release channel "stable", after the same commit SHA
6965-
# has been run and built by Linux flutter_release_builder as part of a release
6966-
# candidate branch (i.e. /flutter-\d+\.\d+-candidate\.\d+/) in the previous
6967-
# target, "Linux docs_publish".
6968-
- name: Linux docs_deploy_stable
6969-
recipe: flutter/docs
6970-
scheduler: release
6971-
bringup: true
6972-
enabled_branches:
6973-
- stable
6974-
presubmit: false
6975-
timeout: 60
6976-
properties:
6977-
cores: "32"
6978-
dependencies: >-
6979-
[
6980-
{"dependency": "dashing", "version": "0.4.0"},
6981-
{"dependency": "firebase", "version": "v11.0.1"}
6982-
]
6983-
tags: >
6984-
["framework", "hostonly", "linux"]
6985-
validation: docs_deploy
6986-
validation_name: Docs_deploy
6987-
firebase_project: docs-flutter-dev
6988-
drone_dimensions:
6989-
- os=Linux

TESTOWNERS

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -311,8 +311,8 @@
311311
/dev/devicelab/bin/tasks/android_display_cutout.dart @reidbaker @flutter/android
312312

313313
## Host only framework tests
314-
# Linux docs_deploy_beta
315314
# Linux docs_deploy_stable
315+
# Linux docs_generate_release
316316
# Linux docs_publish
317317
/dev/bots/docs.sh @Piinks @flutter/framework
318318
# Linux packages_autoroller

0 commit comments

Comments
 (0)