Skip to content

Commit 0836ef6

Browse files
authored
Merge pull request #6579 from grondo/issue#6568
job-exec: fix confusing "job shell exec error" log message
2 parents 921ed27 + 0b12b76 commit 0836ef6

File tree

2 files changed

+2
-18
lines changed

2 files changed

+2
-18
lines changed

src/modules/job-exec/exec.c

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -379,12 +379,12 @@ static void error_cb (struct bulk_exec *exec, flux_subprocess_t *p, void *arg)
379379
}
380380
else {
381381
jobinfo_fatal_error (job,
382-
errnum,
382+
0,
383383
"%s on broker %s (rank %d): %s",
384384
"job shell exec error",
385385
hostname,
386386
rank,
387-
flux_cmd_arg (cmd, 0));
387+
flux_subprocess_fail_error (p));
388388
}
389389
}
390390
else

t/t2400-job-exec-test.t

Lines changed: 0 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -204,20 +204,4 @@ test_expect_success FLUX_SECURITY \
204204
flux job wait-event -vHt 15s $jobid clean &&
205205
flux job status -vvv $jobid
206206
'
207-
208-
if ! grep 'release 7' /etc/centos-release >/dev/null 2>&1 \
209-
&& ! grep 'release 7' /etc/redhat-release >/dev/null 2>&1
210-
then
211-
test_set_prereq NOT_DISTRO7
212-
fi
213-
214-
# The following test does not work on CentOS 7 / RHEL7 since exec errno does
215-
# not work with job-exec (for as yet unknown reason). Skip the test on
216-
# these distros:
217-
test_expect_success NOT_DISTRO7 'job-exec: path to shell is emitted on exec error' '
218-
test_expect_code 127 flux run \
219-
--setattr=exec.job_shell=/foo/flux-shell hostname 2>exec.err &&
220-
test_debug "cat exec.err" &&
221-
grep /foo/flux-shell exec.err
222-
'
223207
test_done

0 commit comments

Comments
 (0)