Skip to content

Commit 0fcc41a

Browse files
authored
Merge pull request #6190 from trws/demote-fedora
matrix: avoid overwriting env elements
2 parents 14c64d2 + dca356b commit 0fcc41a

File tree

1 file changed

+3
-1
lines changed

1 file changed

+3
-1
lines changed

src/test/generate-matrix.py

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -96,7 +96,9 @@ def add_build(
9696
"""Add a build to the matrix.include array"""
9797

9898
# Extra environment to add to this command:
99-
env = env or {}
99+
# NOTE: ensure we copy the dict rather than modify, re-used dicts can cause
100+
# overwriting
101+
env = dict(env) if env is not None else {}
100102

101103
# hwloc tries to look for opengl devices by connecting to a port that might
102104
# sometimes be an x11 port, but more often for us is munge, turn it off

0 commit comments

Comments
 (0)