job-list: add internal func to get job attrs

Problem: In the future, other functions within job-list will
need a list of the job attrs that can be retrieved for each job.

Solution: Create a new private helper function job_attrs(), which
will return a list of valid job attrs.

Author: chu11

src/modules/job-list/job-list.c

@@ -20,6 +20,22 @@
 #include "list.h"
 #include "idsync.h"
 
+static const char *attrs[] = {
+    "userid", "urgency", "priority", "t_submit",
+    "t_depend", "t_run", "t_cleanup", "t_inactive",
+    "state", "name", "ntasks", "nnodes",
+    "ranks", "nodelist", "success", "exception_occurred",
+    "exception_type", "exception_severity",
+    "exception_note", "result", "expiration",
+    "annotations", "waitstatus", "dependencies",
+    NULL
+};
+
+const char **job_attrs (void)
+{
+    return attrs;
+}
+
 static void stats_cb (flux_t *h, flux_msg_handler_t *mh,
                       const flux_msg_t *msg, void *arg)
 {

src/modules/job-list/job-list.h

@@ -25,6 +25,8 @@ struct list_ctx {
     zhashx_t *idsync_waits;
 };
 
+const char **job_attrs (void);
+
 #endif /* _FLUX_JOB_LIST_H */
 
 /*

src/modules/job-list/list.c

@@ -15,6 +15,7 @@
 #endif
 #include <jansson.h>
 #include <flux/core.h>
+#include <assert.h>
 
 #include "src/common/libutil/errno_safe.h"
 #include "src/common/libczmqcontainers/czmq_containers.h"
@@ -556,14 +557,7 @@ int list_attrs_append (json_t *a, const char *attr)
 void list_attrs_cb (flux_t *h, flux_msg_handler_t *mh,
                     const flux_msg_t *msg, void *arg)
 {
-    const char *attrs[] = { "userid", "urgency", "priority", "t_submit",
-                            "t_depend", "t_run", "t_cleanup", "t_inactive",
-                            "state", "name", "ntasks", "nnodes",
-                            "ranks", "nodelist", "success", "exception_occurred",
-                            "exception_type", "exception_severity",
-                            "exception_note", "result", "expiration",
-                            "annotations", "waitstatus", "dependencies",
-                            NULL };
+    const char **attrs;
     json_t *a;
     int i;
 
@@ -572,6 +566,9 @@ void list_attrs_cb (flux_t *h, flux_msg_handler_t *mh,
         goto error;
     }
 
+    attrs = job_attrs ();
+    assert (attrs);
+
     for (i = 0; attrs[i] != NULL; i++) {
         if (list_attrs_append (a, attrs[i]) < 0)
             goto error;