testsuite: cover local-only join/leave

Problem: there is no test coverage that demonstrates that
groups.join and groups.leave RPCs fail with a helpful
error when they are used remotely.

Add a couple tests to t0027-broker-groups.t.

Author: garlick

t/scripts/groups.py

@@ -120,16 +120,25 @@ def join(args):
     """
     h = flux.Flux()
 
-    h.rpc("groups.join", {"name": args.name}).get()
+    h.rpc("groups.join", {"name": args.name}, nodeid=args.rank).get()
     if args.dubjoin:
-        h.rpc("groups.join", {"name": args.name}).get()
+        h.rpc("groups.join", {"name": args.name}, nodeid=args.rank).get()
 
     if args.leave:
-        h.rpc("groups.leave", {"name": args.name}).get()
+        h.rpc("groups.leave", {"name": args.name}, nodeid=args.rank).get()
         if args.dubleave:
             h.rpc("groups.leave", {"name": args.name}).get()
 
 
+def leave(args):
+    """
+    Leave group.
+    """
+    h = flux.Flux()
+
+    h.rpc("groups.leave", {"name": args.name}, nodeid=args.rank).get()
+
+
 LOGGER = logging.getLogger("groups")
 
 
@@ -183,15 +192,28 @@ def main():
     # join
     join_parser = subparsers.add_parser(
         "join",
-        usage="groups join [--dubjoin] [--leave] [--dubleave] name",
+        usage="groups join [--rank N] [--dubjoin] [--leave] [--dubleave] name",
         formatter_class=flux.util.help_formatter(),
     )
     join_parser.add_argument("--dubjoin", action="store_true")
     join_parser.add_argument("--leave", action="store_true")
     join_parser.add_argument("--dubleave", action="store_true")
+    join_parser.add_argument("--rank", type=int, default=flux.constants.FLUX_NODEID_ANY)
     join_parser.add_argument("name")
     join_parser.set_defaults(func=join)
 
+    # leave
+    leave_parser = subparsers.add_parser(
+        "leave",
+        usage="groups leave [--rank N] name",
+        formatter_class=flux.util.help_formatter(),
+    )
+    leave_parser.add_argument(
+        "--rank", type=int, default=flux.constants.FLUX_NODEID_ANY
+    )
+    leave_parser.add_argument("name")
+    leave_parser.set_defaults(func=leave)
+
     args = parser.parse_args()
     args.func(args)
 

t/t0027-broker-groups.t

@@ -30,6 +30,15 @@ test_expect_success 'groups.get on rank > 0 fails with reasonable error' '
 	grep "only available on rank 0" test0.err
 '
 
+test_expect_success 'nonlocal groups.join fails with appropriate error' '
+	test_must_fail ${GROUPSCMD} join --rank 1 foo 2>rmtjoin.err &&
+	grep "restricted to the local broker" rmtjoin.err
+'
+test_expect_success 'nonlocal groups.leave fails with appropriate error' '
+	test_must_fail ${GROUPSCMD} leave --rank 1 foo 2>rmtleave.err &&
+	grep "restricted to the local broker" rmtleave.err
+'
+
 badjoin() {
 	flux python -c "import flux; print(flux.Flux().rpc(\"groups.join\").get())"
 }