Skip to content

Commit 1b1f873

Browse files
chu11mergify[bot]
authored andcommitted
job-list: remove job flags parsing and storing
Problem: The flags from a job's submit event are parsed but never stored or used. A field in the job struct is set aside for it, but it is never initialized. Solution: Remove the parsing and storing of the flags value.
1 parent 97e3abf commit 1b1f873

File tree

2 files changed

+2
-5
lines changed

2 files changed

+2
-5
lines changed

src/modules/job-list/job_state.c

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1236,14 +1236,12 @@ static int submit_context_parse (flux_t *h,
12361236
{
12371237
int urgency;
12381238
int userid;
1239-
int flags;
12401239

12411240
if (!context
12421241
|| json_unpack (context,
1243-
"{ s:i s:i s:i }",
1242+
"{ s:i s:i }",
12441243
"urgency", &urgency,
1245-
"userid", &userid,
1246-
"flags", &flags) < 0) {
1244+
"userid", &userid) < 0) {
12471245
flux_log (h, LOG_ERR, "%s: submit context invalid: %ju",
12481246
__FUNCTION__, (uintmax_t)job->id);
12491247
errno = EPROTO;

src/modules/job-list/job_state.h

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -67,7 +67,6 @@ struct job {
6767
int urgency;
6868
int64_t priority;
6969
double t_submit;
70-
int flags;
7170
flux_job_state_t state;
7271
const char *name;
7372
int ntasks;

0 commit comments

Comments
 (0)