broker: load module with DSO version extension

Problem: currently when a module is loaded by name, only
"name.so" matches, while "name.so.0.0.0" does not.

Match "name.so*" so that a DSO can be found with or without
suffixes.  The first match is used.

Fixes #5255

Author: garlick

src/broker/broker.c

@@ -1190,7 +1190,7 @@ static int mod_svc_cb (const flux_msg_t *msg, void *arg)
 }
 
 /* Load broker module.
- * 'name' is the name to use for the module (NULL = use dso basename minus .so)
+ * 'name' is the name to use for the module (NULL = use dso basename minus ext)
  * 'path' is either a dso path or a dso basename (e.g. "kvs" or "/a/b/kvs.so".
  */
 static int load_module (broker_ctx_t *ctx,
@@ -1211,7 +1211,7 @@ static int load_module (broker_ctx_t *ctx,
             errno = EINVAL;
             return -1;
         }
-        if (asprintf (&pattern, "%s.so", path) < 0) {
+        if (asprintf (&pattern, "%s.so*", path) < 0) {
             errprintf (error, "out of memory");
             return -1;
         }

src/broker/module.c

@@ -549,15 +549,13 @@ flux_msg_t *module_pop_insmod (module_t *p)
 static char *module_name_from_path (const char *s)
 {
     char *path, *name, *cpy;
+    char *cp;
 
     if (!(path = strdup (s))
         || !(name = basename (path)))
         goto error;
-
-    int n = strlen (name);
-    if (n > 3 && streq (&name[n - 3], ".so"))
-        name[n - 3] = '\0';
-
+    if ((cp = strstr (name, ".so")))
+        *cp = '\0';
     if (!(cpy = strdup (name)))
         goto error;
     free (path);