python: use job-list "all" attr

Problem: The python bindings have a VALID_ATTRS list that is
maintained to grab all attrs from a job.  This is no longer
necessary with the job-list "all" attr.

Solution: Use the "all" attr and remove VALID_ATTRS.  As a side
effect, a copy of valid attrs must be added to tests when checking
for the list of legal attrs returned from job-list.list-attrs.

Author: chu11

src/bindings/python/flux/job/list.py

@@ -17,35 +17,6 @@
 from flux.rpc import RPC
 
 
-VALID_ATTRS = [
-    "userid",
-    "urgency",
-    "priority",
-    "t_submit",
-    "t_depend",
-    "t_run",
-    "t_cleanup",
-    "t_inactive",
-    "state",
-    "name",
-    "ntasks",
-    "nnodes",
-    "ranks",
-    "nodelist",
-    "waitstatus",
-    "success",
-    "exception_occurred",
-    "exception_type",
-    "exception_severity",
-    "exception_note",
-    "result",
-    "expiration",
-    "annotations",
-    "dependencies",
-    "all",
-]
-
-
 class JobListRPC(RPC):
     def get_jobs(self):
         return self.get()["jobs"]
@@ -178,7 +149,7 @@ class JobList:
     def __init__(
         self,
         flux_handle,
-        attrs=VALID_ATTRS,
+        attrs=["all"],
         filters=[],
         ids=[],
         user=None,

src/cmd/flux-pstree.py

@@ -162,10 +162,9 @@ def load_tree(
     #  This may fail if the instance hasn't loaded the job-list module
     #   or if the current user is not owner
     #
-    attrs = flux.job.list.VALID_ATTRS
     try:
         jobs_rpc = JobList(
-            flux.Flux(uri), ids=jobids, filters=filters, attrs=attrs
+            flux.Flux(uri), ids=jobids, filters=filters, attrs=["all"]
         ).fetch_jobs()
         jobs = jobs_rpc.get_jobs()
     except (OSError, FileNotFoundError):

t/python/t0010-job.py

@@ -28,7 +28,6 @@
 import flux.constants
 from flux import job
 from flux.job import Jobspec, JobspecV1, ffi, JobID, JobInfo
-from flux.job.list import VALID_ATTRS
 from flux.job.stats import JobStats
 from flux.future import Future
 
@@ -453,8 +452,35 @@ def test_24_jobid(self):
                     self.assertEqual(getattr(jobid, key), test[key])
 
     def test_25_job_list_attrs(self):
+        expected_attrs = [
+            "userid",
+            "urgency",
+            "priority",
+            "t_submit",
+            "t_depend",
+            "t_run",
+            "t_cleanup",
+            "t_inactive",
+            "state",
+            "name",
+            "ntasks",
+            "nnodes",
+            "ranks",
+            "nodelist",
+            "waitstatus",
+            "success",
+            "exception_occurred",
+            "exception_type",
+            "exception_severity",
+            "exception_note",
+            "result",
+            "expiration",
+            "annotations",
+            "dependencies",
+            "all",
+        ]
         valid_attrs = self.fh.rpc("job-list.list-attrs", "{}").get()["attrs"]
-        self.assertEqual(set(valid_attrs), set(VALID_ATTRS))
+        self.assertEqual(set(valid_attrs), set(expected_attrs))
 
     def test_30_job_stats_sync(self):
         stats = JobStats(self.fh)