Merge pull request #6821 from chu11/issue6636_flux_module_error_message

flux-module: require argument for flux module stats

Author: mergify[bot]

src/cmd/flux-module.c

@@ -648,11 +648,11 @@ int cmd_stats (optparse_t *p, int argc, char **argv)
     flux_future_t *f = NULL;
     flux_t *h;
 
-    if ((n = optparse_option_index (p)) < argc - 1) {
+    if ((n = optparse_option_index (p)) != (argc - 1)) {
         optparse_print_usage (p);
         exit (1);
     }
-    service = n < argc ? argv[n++] : "broker";
+    service = argv[n];
     nodeid = FLUX_NODEID_ANY;
 
     if (!(h = flux_open (NULL, 0)))

t/t0003-module.t

@@ -206,6 +206,11 @@ test_expect_success 'flux module stats --rusage --parse maxrss works' '
 	test "$RSS" -gt 0
 '
 
+test_expect_success 'flux module stats with no args is an error' '
+	test_must_fail flux module stats 2> usage.out &&
+	grep -i "usage" usage.out
+'
+
 # try to hit some error cases
 
 test_expect_success 'flux module with no arguments prints usage and fails' '