Skip to content

Commit 52d9d80

Browse files
authored
Merge pull request #6817 from grondo/t-fixes
testsuite: add one missing test and fix failing test in ci
2 parents 3b1ad4c + 76771ea commit 52d9d80

File tree

2 files changed

+12
-2
lines changed

2 files changed

+12
-2
lines changed

t/Makefile.am

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -222,6 +222,7 @@ TESTSCRIPTS = \
222222
t2618-job-shell-signal.t \
223223
t2619-job-shell-hwloc.t \
224224
t2620-job-shell-mustache.t \
225+
t2621-job-shell-plugin-fork.t \
225226
t2710-python-cli-submit.t \
226227
t2711-python-cli-run.t \
227228
t2713-python-cli-bulksubmit.t \

t/t0019-tbon-config.t

Lines changed: 11 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -76,9 +76,18 @@ test_expect_success 'tbon.interface-hint=default-route works' '
7676
flux start -Stbon.interface-hint=default-route -Stbon.prefertcp=1 \
7777
${ARGS} -s2 true
7878
'
79+
# Note: the following test may fail if for some reason bind() fails on the
80+
# interface associated with the hostname. This may occur, for example, under
81+
# docker with --network=host when the host does not allow processes to bind
82+
# to the shared interface. Therefore allow success or a specific error to
83+
# determine success of this test.
7984
test_expect_success 'tbon.interface-hint=hostname works' '
80-
flux start -Stbon.interface-hint=hostname -Stbon.prefertcp=1 \
81-
${ARGS} -s2 true
85+
test_might_fail flux start \
86+
-Stbon.interface-hint=hostname \
87+
-Stbon.prefertcp=1 \
88+
${ARGS} -s2 echo ok >interface-hostname.out 2>&1 &&
89+
(grep ok interface-hostname.out ||
90+
grep "Cannot assign requested address" interface-hostname.out)
8291
'
8392
test_expect_success 'tbon.interface-hint defaults to default-router' '
8493
flux start ${ARGS} flux getattr tbon.interface-hint >defhint.out &&

0 commit comments

Comments
 (0)