testsuite: cover subprocess kill error code

garlick · garlick · commit 6f4c1b99596e · 2023-06-05T16:11:50.000-07:00
Problem: there is no test coverage the ensures a subprocess
kill RPC fails with ESRCH when the pid cannot be found.

Add a test to t0005-rexec.t.
diff --git a/t/t0005-rexec.t b/t/t0005-rexec.t
@@ -278,4 +278,9 @@ test_expect_success NO_CHAIN_LINT 'ps, kill fail remotely on rank 0' '
 	wait_rexec_process_count 0 0
 '
 
+test_expect_success NO_CHAIN_LINT 'kill fails with ESRCH when pid is unknown' '
+	test_must_fail $rexec_script kill 15 12345678 2>kill.err &&
+	grep "No such process" kill.err
+'
+
 test_done

Original file line number	Diff line number	Diff line change
`@@ -278,4 +278,9 @@ test_expect_success NO_CHAIN_LINT 'ps, kill fail remotely on rank 0' '`
`278`	`278`	`wait_rexec_process_count 0 0`
`279`	`279`	`'`
`280`	`280`
	`281`	`+test_expect_success NO_CHAIN_LINT 'kill fails with ESRCH when pid is unknown' '`
	`282`	`+ test_must_fail $rexec_script kill 15 12345678 2>kill.err &&`
	`283`	`+ grep "No such process" kill.err`
	`284`	`+'`
	`285`	`+`
`281`	`286`	`test_done`