Skip to content

Commit 77f472d

Browse files
authored
Merge pull request #6836 from grondo/issue#6835
require Lua `posix` in `configure` and document some tips for running the testsuite
2 parents e6ca1cd + f4718a9 commit 77f472d

File tree

4 files changed

+21
-2
lines changed

4 files changed

+21
-2
lines changed

README.md

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -33,10 +33,14 @@ are available for [redhat](scripts/install-deps-rpm.sh) and
3333
```
3434
./autogen.sh # skip if building from a release tarball
3535
./configure
36-
make
37-
make check
36+
make -jN
37+
make -jN check
3838
```
3939

40+
> [!TIP]
41+
> `make check` runs many tests. Use of `-jN` recommended.
42+
> For more details about the testsuite, see the [README](t/README.md).
43+
4044
##### VSCode Dev Containers
4145

4246
If you use VSCode we have a dev container and [instructions](vscode.md).

configure.ac

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -390,6 +390,13 @@ AM_CONDITIONAL([ENABLE_PYLINT], [test "x$PYLINT" = "xpylint"])
390390
AX_PROG_LUA([5.1],[5.5])
391391
AX_LUA_HEADERS
392392
AX_LUA_LIBS
393+
AC_MSG_CHECKING([for luaposix])
394+
if $LUA -l posix -e ''; then
395+
AC_MSG_RESULT([yes])
396+
else
397+
AC_MSG_RESULT([no])
398+
AC_MSG_FAILURE([Could not find required Lua posix module])
399+
fi
393400
X_AC_ZEROMQ
394401
X_AC_JANSSON
395402
PKG_CHECK_MODULES([LIBSYSTEMD], [libsystemd >= 0.23],

scripts/install-deps-macos.sh

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -24,6 +24,7 @@ brew install \
2424
hwloc \
2525
sqlite \
2626
lua \
27+
luarocks \
2728
python3 \
2829
cffi \
2930
libyaml \
@@ -35,4 +36,7 @@ source macos-venv/bin/activate
3536
pip3 install setuptools
3637
pip3 install -r scripts/requirements-dev.txt
3738

39+
# luaposix now required for configure:
40+
luarocks install luaposix
41+
3842
echo "Now run scripts/configure-macos.sh"

t/README.md

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -124,6 +124,10 @@ running the testsuite against an installed version of flux-core.
124124
The environment variable `FLUX_TEST_VALGRIND` may be set to `t`
125125
to run tests under valgrind.
126126

127+
The environment variable `FLUX_TESTS_LOGFILE` may be set to `t` to force
128+
most tests to generate a verbose log as `$TEST_NAME.output` when debugging
129+
tests.
130+
127131

128132
Skipping Tests
129133
--------------

0 commit comments

Comments
 (0)