resource: fix leak in update_properties()

grondo · grondo · commit 88dfcedda4e3 · 2024-04-05T13:11:41.000-07:00
Problem: If there are no properties in the 'all' resource set
then alloc_ranks idset is leaked.

Free alloc_ranks before returning if there's no properties.
diff --git a/src/modules/resource/status.c b/src/modules/resource/status.c
@@ -218,6 +218,7 @@ static int update_properties (struct rlist *alloc, struct rlist *all)
     if (!(props = get_properties (all))
         || json_object_size (props) == 0) {
         json_decref (props);
+        idset_destroy (alloc_ranks);
         return 0;
     }
     json_object_foreach (props, name, val) {

Original file line number	Diff line number	Diff line change
`@@ -218,6 +218,7 @@ static int update_properties (struct rlist alloc, struct rlist all)`
`218`	`218`	`if (!(props = get_properties (all))`
`219`	`219`	`\|\| json_object_size (props) == 0) {`
`220`	`220`	`json_decref (props);`
	`221`	`+ idset_destroy (alloc_ranks);`
`221`	`222`	`return 0;`
`222`	`223`	`}`
`223`	`224`	`json_object_foreach (props, name, val) {`