testsuite: add test for buggy flux-job wait-event context matching

grondo · grondo · commit 90ec0b24149b · 2024-04-01T21:13:32.000Z
Problem: No test in t2231-job-info-eventlog-watch.t ensures that the
flux-job wait-event -m, --match-context=KEY=VAL doesn't produce a
match when the VALUE matches but KEY does not.

Add a test.
diff --git a/t/t2231-job-info-eventlog-watch.t b/t/t2231-job-info-eventlog-watch.t
@@ -182,6 +182,11 @@ test_expect_success 'flux job wait-event w/ bad match-context fails (invalid val
 	test_must_fail fj_wait_event --match-context=type=foo $JOBID exception
 '
 
+# Note: in test below, foo=0 would match severity=0 in buggy version
+test_expect_success 'flux job wait-event w/ bad match-context fails (issue #5845)' '
+	test_must_fail fj_wait_event --match-context=foo=0 $JOBID exception
+'
+
 test_expect_success 'flux job wait-event w/ bad match-context fails (invalid input)' '
 	test_must_fail fj_wait_event --match-context=foo $JOBID exception
 '

Original file line number	Diff line number	Diff line change
`@@ -182,6 +182,11 @@ test_expect_success 'flux job wait-event w/ bad match-context fails (invalid val`
`182`	`182`	`test_must_fail fj_wait_event --match-context=type=foo $JOBID exception`
`183`	`183`	`'`
`184`	`184`
	`185`	`+# Note: in test below, foo=0 would match severity=0 in buggy version`
	`186`	`+test_expect_success 'flux job wait-event w/ bad match-context fails (issue #5845)' '`
	`187`	`+ test_must_fail fj_wait_event --match-context=foo=0 $JOBID exception`
	`188`	`+'`
	`189`	`+`
`185`	`190`	`test_expect_success 'flux job wait-event w/ bad match-context fails (invalid input)' '`
`186`	`191`	`test_must_fail fj_wait_event --match-context=foo $JOBID exception`
`187`	`192`	`'`