Skip to content

Commit a892a0f

Browse files
committed
housekeeping: restore start/finish debug logging
Problem: housekeeping debug logs that were recently removed to reduce noise turned out to be handy when diagnosing #6179. Restore 2 out of 3 removed debug log messages.
1 parent 8417d2a commit a892a0f

File tree

1 file changed

+11
-1
lines changed

1 file changed

+11
-1
lines changed

src/modules/job-manager/housekeeping.c

Lines changed: 11 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -317,6 +317,14 @@ static void set_failed_reason (const char **s, const char *reason)
317317
*s = "multiple failure modes";
318318
}
319319

320+
static void bulk_start (struct bulk_exec *bulk_exec, void *arg)
321+
{
322+
struct allocation *a = arg;
323+
flux_t *h = a->hk->ctx->h;
324+
325+
flux_log (h, LOG_DEBUG, "housekeeping: %s started", idf58 (a->id));
326+
}
327+
320328
static void bulk_exit (struct bulk_exec *bulk_exec,
321329
void *arg,
322330
const struct idset *ids)
@@ -376,7 +384,9 @@ static void bulk_exit (struct bulk_exec *bulk_exec,
376384
static void bulk_complete (struct bulk_exec *bulk_exec, void *arg)
377385
{
378386
struct allocation *a = arg;
387+
flux_t *h = a->hk->ctx->h;
379388

389+
flux_log (h, LOG_DEBUG, "housekeeping: %s complete", idf58 (a->id));
380390
allocation_remove (a);
381391
}
382392

@@ -830,7 +840,7 @@ struct housekeeping *housekeeping_ctx_create (struct job_manager *ctx)
830840
}
831841

832842
static struct bulk_exec_ops bulk_ops = {
833-
.on_start = NULL,
843+
.on_start = bulk_start,
834844
.on_exit = bulk_exit,
835845
.on_complete = bulk_complete,
836846
.on_output = bulk_output,

0 commit comments

Comments
 (0)