job-archive: allow guests to access module stats

garlick · garlick · commit a90749ab4def · 2023-06-21T15:22:31.000Z
Problem: flux module stats is generally open to guests,
but the RPC override in the job-archive module is not.

Open job-archive.stats-get to guests.
Add a test to t2250-job-archive.t.
diff --git a/src/modules/job-archive/job-archive.c b/src/modules/job-archive/job-archive.c
@@ -604,7 +604,8 @@ static int process_config (struct job_archive_ctx *ctx)
 }
 
 static const struct flux_msg_handler_spec htab[] = {
-    { FLUX_MSGTYPE_REQUEST, "job-archive.stats-get", stats_get_cb, 0 },
+    { FLUX_MSGTYPE_REQUEST, "job-archive.stats-get",
+      stats_get_cb, FLUX_ROLE_USER },
     FLUX_MSGHANDLER_TABLE_END,
 };
 
diff --git a/t/t2250-job-archive.t b/t/t2250-job-archive.t
@@ -280,6 +280,11 @@ test_expect_success 'job-archive: get module stats' '
         flux module stats job-archive
 '
 
+test_expect_success 'flux module stats job-archive is open to guests' '
+	FLUX_HANDLE_ROLEMASK=0x2 \
+	    flux module stats job-archive >/dev/null
+'
+
 test_expect_success 'job-archive: unload module' '
         flux module unload job-archive
 '

Original file line number	Diff line number	Diff line change
`@@ -604,7 +604,8 @@ static int process_config (struct job_archive_ctx *ctx)`
`604`	`604`	`}`
`605`	`605`
`606`	`606`	`static const struct flux_msg_handler_spec htab[] = {`
`607`		`- { FLUX_MSGTYPE_REQUEST, "job-archive.stats-get", stats_get_cb, 0 },`
	`607`	`+ { FLUX_MSGTYPE_REQUEST, "job-archive.stats-get",`
	`608`	`+ stats_get_cb, FLUX_ROLE_USER },`
`608`	`609`	`FLUX_MSGHANDLER_TABLE_END,`
`609`	`610`	`};`
`610`	`611`
Original file line number	Diff line number	Diff line change
`@@ -280,6 +280,11 @@ test_expect_success 'job-archive: get module stats' '`
`280`	`280`	`flux module stats job-archive`
`281`	`281`	`'`
`282`	`282`
	`283`	`+test_expect_success 'flux module stats job-archive is open to guests' '`
	`284`	`+ FLUX_HANDLE_ROLEMASK=0x2 \`
	`285`	`+ flux module stats job-archive >/dev/null`
	`286`	`+'`
	`287`	`+`
`283`	`288`	`test_expect_success 'job-archive: unload module' '`
`284`	`289`	`flux module unload job-archive`
`285`	`290`	`'`