job-info: cleanup update lookups on disconnect

Problem: On disconnect, cleaning up update-lookups was forgotten.

Add cleanup update_lookups via a new update_lookup_cleanup() function.

Author: chu11

src/modules/job-info/job-info.c

@@ -117,8 +117,10 @@ static void info_ctx_destroy (struct info_ctx *ctx)
             guest_watch_cleanup (ctx);
             zlist_destroy (&ctx->guest_watchers);
         }
-        if (ctx->update_lookups)
+        if (ctx->update_lookups) {
+            update_lookup_cleanup (ctx);
             zlist_destroy (&ctx->update_lookups);
+        }
         if (ctx->update_watchers) {
             update_watch_cleanup (ctx);
             zlist_destroy (&ctx->update_watchers);

src/modules/job-info/update.c

@@ -689,6 +689,23 @@ void update_watch_cleanup (struct info_ctx *ctx)
     }
 }
 
+void update_lookup_cleanup (struct info_ctx *ctx)
+{
+    struct update_ctx *uc;
+
+    while ((uc = zlist_pop (ctx->update_lookups))) {
+        const flux_msg_t *msg;
+        msg = flux_msglist_first (uc->msglist);
+        while (msg) {
+            if (flux_respond_error (ctx->h, msg, ENOSYS, NULL) < 0)
+                flux_log_error (ctx->h, "%s: flux_respond_error",
+                                __FUNCTION__);
+            msg = flux_msglist_next (uc->msglist);
+        }
+        update_ctx_destroy (uc);
+    }
+}
+
 int update_watch_count (struct info_ctx *ctx)
 {
     struct update_ctx *uc;

src/modules/job-info/update.h

@@ -32,6 +32,8 @@ void update_watchers_cancel (struct info_ctx *ctx,
 
 void update_watch_cleanup (struct info_ctx *ctx);
 
+void update_lookup_cleanup (struct info_ctx *ctx);
+
 int update_watch_count (struct info_ctx *ctx);
 
 #endif /* ! _FLUX_JOB_INFO_UPDATE_H */