broker: provision dead brokers for flub replacement

Problem: there is no way to replace a node in Flux instance
that goes down.

Call overlay_flub_provision () when a rank goes offline
so that the flub allocator can allocate its rank to a replacement.

Author: garlick

src/broker/state_machine.c

@@ -836,6 +836,19 @@ static void broker_online_cb (flux_future_t *f, void *arg)
         return;
     }
 
+    /* A broker that drops out of s->quorum.online is provisioned
+     * for replacement via flub.
+     */
+    if (s->quorum.online) {
+        unsigned int id;
+        id = idset_first (s->quorum.online);
+        while (id != IDSET_INVALID_ID) {
+            if (!idset_test (ids, id))
+                (void)overlay_flub_provision (s->ctx->overlay, id, id);
+            id = idset_next (s->quorum.online, id);
+        }
+    }
+
     idset_destroy (s->quorum.online);
     s->quorum.online = ids;
     if (idset_count (s->quorum.online) >= s->quorum.size)