Merge pull request #4335 from grondo/fix-uri-resolve-error

python: fix confusing error message from pid URI resolver

Author: mergify[bot]

src/bindings/python/flux/uri/resolvers/pid.py

@@ -59,7 +59,7 @@ def _get_broker_child(pid):
                     return cpid
         except FileNotFoundError:
             pass
-    raise ValueError(f"PID {broker_pid} is a flux-broker and no child found")
+    raise ValueError(f"PID {pid} is a flux-broker and no child found")
 
 
 def _proc_has_task_children():

t/t2802-uri-cmd.t

@@ -4,7 +4,7 @@ test_description='Test flux uri command'
 
 . $(dirname $0)/sharness.sh
 
-test_under_flux 1
+test_under_flux 2
 
 testssh="${SHARNESS_TEST_SRCDIR}/scripts/tssh"
 
@@ -51,6 +51,11 @@ test_expect_success 'flux-uri pid resolver works on flux-broker with fallback' '
 	  test "$(flux uri pid:$(flux getattr broker.pid))" =  "$FLUX_URI"
 	)
 '
+test_expect_success 'flux-uri pid resolver fails if broker has no child' '
+	test_must_fail flux uri pid:$(flux exec -r 1 flux getattr broker.pid) \
+		>broker-no-child.out 2>&1 &&
+	grep "is a flux-broker and no child found" broker-no-child.out
+'
 test_expect_success 'flux-uri pid resolver fails for nonexistent pid' '
 	test_expect_code 1 flux uri pid:123456
 '