testsuite: fix racy flux job attach test

garlick · garlick · commit c56db249296b · 2024-08-10T11:53:06.000-07:00
Problem: when t2500-job-attach.t is run on a busy system, the "attach: reports job shell Killed if job shell is killed" test sometimes fails. 'flux submit --wait-event=exec.shell.start kill -9 $PPID' may fail if the shell is terminated before shell.start can be posted. Drop the --wait-event as it's not really needed per @grondo. Fixes #6211
diff --git a/t/t2500-job-attach.t b/t/t2500-job-attach.t
@@ -129,7 +129,7 @@ test_expect_success 'attach: reports Terminated when tasks are terminated' '
 	grep Terminated terminated.err
 '
 test_expect_success 'attach: reports job shell Killed if job shell is killed' '
-	id=$(flux submit --wait-event=exec.shell.start sh -c "kill -9 \$PPID") &&
+	id=$(flux submit sh -c "kill -9 \$PPID") &&
 	test_must_fail_or_be_terminated flux job attach $id 2>shell-killed.out &&
 	grep "job shell Killed" shell-killed.out
 '

Original file line number	Diff line number	Diff line change
`@@ -129,7 +129,7 @@ test_expect_success 'attach: reports Terminated when tasks are terminated' '`
`129`	`129`	`grep Terminated terminated.err`
`130`	`130`	`'`
`131`	`131`	`test_expect_success 'attach: reports job shell Killed if job shell is killed' '`
`132`		`- id=$(flux submit --wait-event=exec.shell.start sh -c "kill -9 \$PPID") &&`
	`132`	`+ id=$(flux submit sh -c "kill -9 \$PPID") &&`
`133`	`133`	`test_must_fail_or_be_terminated flux job attach $id 2>shell-killed.out &&`
`134`	`134`	`grep "job shell Killed" shell-killed.out`
`135`	`135`	`'`